You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR renames the Firestore tests in the JS/Web SDK to use the term 'enterprise' instead of 'nameddb', aligning it with the naming conventions used in the Android and iOS SDKs.
Renamed scripts in packages/firestore/package.json.
Updated .github/workflows/test-changed-firestore.yml to reference the renamed scripts.
Chrome-based tests (the required set) now use the enterprise name.
Firefox and Webkit tests also use the enterprise name but remain non-blocking.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request renames several test scripts in packages/firestore/package.json, replacing the :nameddb suffix with :enterprise to better reflect their purpose. These changes are applied consistently across lite, browser, and node test configurations, as well as the aggregate test:all and test:all:ci scripts. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames the Firestore tests in the JS/Web SDK to use the term 'enterprise' instead of 'nameddb', aligning it with the naming conventions used in the Android and iOS SDKs.
packages/firestore/package.json..github/workflows/test-changed-firestore.ymlto reference the renamed scripts.enterprisename.enterprisename but remain non-blocking.