Skip to content

chore(firestore): rename nameddb tests to enterprise#9863

Merged
wu-hui merged 1 commit intomainfrom
firestore-enterprise-rename
Apr 21, 2026
Merged

chore(firestore): rename nameddb tests to enterprise#9863
wu-hui merged 1 commit intomainfrom
firestore-enterprise-rename

Conversation

@wu-hui
Copy link
Copy Markdown
Contributor

@wu-hui wu-hui commented Apr 20, 2026

This PR renames the Firestore tests in the JS/Web SDK to use the term 'enterprise' instead of 'nameddb', aligning it with the naming conventions used in the Android and iOS SDKs.

  • Renamed scripts in packages/firestore/package.json.
  • Updated .github/workflows/test-changed-firestore.yml to reference the renamed scripts.
  • Chrome-based tests (the required set) now use the enterprise name.
  • Firefox and Webkit tests also use the enterprise name but remain non-blocking.

@wu-hui wu-hui requested review from a team as code owners April 20, 2026 19:24
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 20, 2026

⚠️ No Changeset found

Latest commit: 71917e8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request renames several test scripts in packages/firestore/package.json, replacing the :nameddb suffix with :enterprise to better reflect their purpose. These changes are applied consistently across lite, browser, and node test configurations, as well as the aggregate test:all and test:all:ci scripts. I have no feedback to provide.

@wu-hui wu-hui merged commit c9f45fa into main Apr 21, 2026
58 of 65 checks passed
@wu-hui wu-hui deleted the firestore-enterprise-rename branch April 21, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants