Added complete contents of fdc3-get-agent and fdc3-agent-proxy packag…#1813
Added complete contents of fdc3-get-agent and fdc3-agent-proxy packag…#1813
Conversation
…es to their index.ts files.
✅ Deploy Preview for fdc3 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@robmoffat should I assume you want to get this into the FDC3 2.2.2 release? |
| Logger, | ||
| throwIfUndefined, |
There was a problem hiding this comment.
I don't think either of these need exporting
There was a problem hiding this comment.
I've removed throwIfUndefined in latest push as requested, but I think things like Logger we should include: it turns out that we are duplicating the logger classes in both fdc3-agent-proxy and fdc3-get-agent.
|
@robmoffat how sure are you that all the newly exported properties should be exported? I see a few that I'm not sure about - for example does it make sense for the 3rd party code to use the Logger that's setup for a specific package? Some of the fields look like they may be internal implementation details. As discussed at the Sail meeting it would be worth another pass on this to refine the list. |
kriswest
left a comment
kriswest
left a comment
There was a problem hiding this comment.
Discussed with Rob, who will give this another pass and remove anything that doesn't need exporting, then re-request review. Yes it does need to go into the FDC3 2.2.2 release.
|
|
Over to you @kriswest |
2 participants
…es to their index.ts files.
Describe your change
Completes missing exports from
index.tsinfdc3-get-agentandfdc3-agent-proxyRelated Issue
Fix for #1812
Contributor License Agreement
Review Checklist
DesktopAgent,Channel,PrivateChannel,Listener,Bridging)?JSDoc comments on interfaces and types should be matched to the main documentation in /docs
Conformance test definitions should cover all required aspects of an FDC3 Desktop Agent implementation, which are usually marked with a MUST keyword, and optional features (SHOULD or MAY) where the format of those features is defined
The Web Connection protocol and Desktop Agent Communication Protocol schemas must be able to support all necessary aspects of the Desktop Agent API, while Bridging must support those aspects necessary for Desktop Agents to communicate with each other
npm run build) run and the results checked in?Generated code will be found at
/src/api/BrowserTypes.tsand/or/src/bridging/BridgingTypes.tsBaseContextschema applied viaallOf(as it is in existing types)?titleanddescriptionprovided for all properties defined in the schema?npm run build) run and the results checked in?Generated code will be found at
/src/context/ContextTypes.ts