Feature: Enable drag and drop reordering for Pinned Sidebar items

[kalmix]

Resolved / Related Issues

• Closes Feature: Replace content dialog with sidebar drag and drop for rearranging pinned items #15430

Code Changes

• Implemented direct drag-and-drop reordering for pinned sidebar items using the new IDraggableSidebarItemModel interface and the related sidebar drag/drop event flow updates.

• Added UpdateOrderSilently and SuspendSync() to PinnedFoldersManager so pinned items can be reordered safely while temporarily pausing sync side effects.

• Updated the Home Page Quick Access widget to reorder items with Items.Move() instead of clearing and rebuilding the collection, reducing UI flicker during reorder operations.

• Added Move(int oldIndex, int newIndex) to BulkConcurrentObservableCollection so observable collections can shift items in place instead of forcing a full reload.

• Added a force parameter to WindowsQuickAccessService.PinToSidebarAsync so Windows Shell pins can be reapplied in the exact intended order when syncing reorder changes back to the OS.

• Replaced the previous app-level COM exception workaround with localized drag-and-drop exception handling in the sidebar pipeline, including a dedicated DragDropExceptionHelper for expected stale OLE/COM drag failures.

• Hardened FilesystemHelpers to validate drag payload availability and safely handle dead OLE payload access without crashing the app.

• Fixed a null crash in StorageFileExtensions.AreItemsAlreadyInFolder() by safely handling Path.GetDirectoryName(...) results before comparison.

• Wrapped sidebar drag/drop deferral and payload access paths in guarded try/catch/finally flows so interrupted or stale drops fail gracefully instead of tearing down the app.

Before:

before.mp4

After:

after.mp4

Steps used to test these changes

1. Opened Files
2. Pinned multiple folders to the sidebar
3. Dragged a pinned folder to a different position in the sidebar
4. Verified the folder drops and stays in the new position naturally
5. Checked the Home Page Quick Access widget to confirm it matches the new order without flickering or reloading
6. Opened Windows File Explorer in the background
7. Started dragging a pinned folder in the sidebar to reorder it, and then quickly grabbed another sidebar item while the first drag was resolving
8. Confirmed the app securely handles the underlying COMException and no longer crashes
9. Restarted the app to verify the new pinned folder order persists

[yair100]

@kalmix I haven't reviewed the code yet, but I tested the changes. It works pretty well but I noticed that I can't drag Recycle Bin to a different position. I'm not sure if this is specific to Recycle Bin or if it's because it's the last item in the list.

As a side note, can you remove the old content dialog since it's no longer needed?

[kalmix]

@yair100 Sorry, I missed Shell: paths like Recycle Bin. I fixed it now; I also removed the old dialog.

[kalmix]

I've also updated the "drop on center" behavior to better align with the Explorer. For pinned items, dropping on the center now performs a Create Link action instead of a move operation, while non-pinned items continue to be moved as before. In addition, I added support for drag-and-drop pinning.

[Josh65-2201]

Seems to be no way to drag an item to the first position. I have to drag the item to the second from top and then the first one down.

Also has issues keeping Gallery pined when the list is updated

\SHELL\OgAfAOTpNjks2e5OqFq8FtXqCBkmAAEAJgDvvhAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAUAAAA\_AAAAPYAycAeDOsAAQAAVgAAADFTUFOmamMoPZXSEbXWAMBP2RjQKQAAACAAAAAAERAAABYAAAAUAB9B6mWI6BwOIE6apu3NAhLIfAAAAAARAAAAGQAAAAATAAAAAAAAIAAAAABgAAAAMVNQU_TuyDAyqOJBqzLjw8oo_SkRAAAAEwAAAAATAAAAAAAAABEAAAAEAAAAAAsAAAD__wAAEQAAAAMAAAAAEwAAAAUAAAARAAAAFAAAAAALAAAAAAAAAAAAAAAxAAAAMVNQU35WhU_w__VNsdmYsxT_BykVAAAACAAAAAAfAAAAAQAAAAAAAAAAAAAAAAAAAAAAAAA=

[kalmix]

@Josh65-2201 Yes, sorry I blocked users from draging to the top because I was running into a UI virtualization bug that left a blank space and also because the file explorer doesn't allow you to do that either but now i've fixed it using Manager_DataChanged() instead of Move(), and since we're already "reseting" the pinned section we can get around that.

Regarding the Gallery issue, thanks for pointing that out, in this case Gallery is an outlier that also causes problem with the current state of Files (try it on the prod app), I gave my best shot at fixing this by normalizing the PIDL paths and also adding a fallback remove COM verb and then to keep everything in sync I added a FileSystemWatcher that tracks the Quick Access registry.

[Josh65-2201]

Working perfectly now.