Skip to content

Code Quality: Package with Microsoft.Windows.SDK.BuildTools.MSIX#18228

Draft
0x5bfa wants to merge 1 commit intofiles-community:mainfrom
0x5bfa:5bfa/CQ-MSIXPackage
Draft

Code Quality: Package with Microsoft.Windows.SDK.BuildTools.MSIX#18228
0x5bfa wants to merge 1 commit intofiles-community:mainfrom
0x5bfa:5bfa/CQ-MSIXPackage

Conversation

@0x5bfa
Copy link
Copy Markdown
Member

@0x5bfa 0x5bfa commented Mar 8, 2026

Resolved / Related Issues

Replaces existing scripts with the ones provided by the official packager.

Steps used to test these changes

  1. Restore Files
    cd D:\Source\Files\src\Files.App
    msbuild ../../Files.slnx /t:Restore /p:Platform=x64 /p:Configuration=Release
    
  2. Build and package
    msbuild Files.App.csproj /p:Platform=x64 /p:Configuration=Release /p:AppxPackageDir=D:\Source\Files\artifacts\
    
  3. Check if the generated msixbundle contains msix files for x64 and arm64 (unzip it to see files inside)
    image
  4. Check if each msix contains the appropriate 7z binary (unzip it to see files inside)
    image
    image

@0x5bfa
Copy link
Copy Markdown
Member Author

0x5bfa commented Mar 8, 2026

I've reopened PR since there are so many conflicted files on rebase.

@yair100
Copy link
Copy Markdown
Member

yair100 commented Apr 14, 2026

@0x5bfa the packaging project has already been removed. Is there any reason to keep this PR open?

@0x5bfa
Copy link
Copy Markdown
Member Author

0x5bfa commented Apr 14, 2026

This is primarily to use official scripts instead of ones that exist in this repo. It's a lot safer IMHO.

@yair100
Copy link
Copy Markdown
Member

yair100 commented Apr 14, 2026

Safer in terms of security?

@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-MSIXPackage branch from 5819dda to c6320de Compare April 15, 2026 05:30
@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-MSIXPackage branch from c6320de to ecf3d2f Compare April 15, 2026 05:30
@0x5bfa
Copy link
Copy Markdown
Member Author

0x5bfa commented Apr 15, 2026

Safer in terms of security?

Yeah, less scripts better it is IMHO. Like, we don't know how people can breach our codebase lol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants