Code Quality: Package with Microsoft.Windows.SDK.BuildTools.MSIX#18228
Draft
0x5bfa wants to merge 1 commit intofiles-community:mainfrom
Draft
Code Quality: Package with Microsoft.Windows.SDK.BuildTools.MSIX#182280x5bfa wants to merge 1 commit intofiles-community:mainfrom
0x5bfa wants to merge 1 commit intofiles-community:mainfrom
Conversation
Member
Author
|
I've reopened PR since there are so many conflicted files on rebase. |
Member
|
@0x5bfa the packaging project has already been removed. Is there any reason to keep this PR open? |
Member
Author
|
This is primarily to use official scripts instead of ones that exist in this repo. It's a lot safer IMHO. |
Member
|
Safer in terms of security? |
5819dda to
c6320de
Compare
c6320de to
ecf3d2f
Compare
Member
Author
Yeah, less scripts better it is IMHO. Like, we don't know how people can breach our codebase lol. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Replaces existing scripts with the ones provided by the official packager.
Steps used to test these changes