Draft
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR downgrades the fvm4 dependency from version 4.7.4 to 4.7.3, removes the "nv28-dev" feature flag, and configures GCC 12 across CI jobs to address compilation compatibility issues.
- Downgrades fvm4 and fvm4_shared from version 4.7.4 to 4.7.3
- Removes the "nv28-dev" feature from fvm4 dependency
- Adds GCC 12 installation and environment configuration to all three CI jobs (check, cgo-bindings, supraseal)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rust/Cargo.toml | Downgrades fvm4 packages to version 4.7.3 and removes nv28-dev feature flag |
| .github/workflows/ci.yml | Installs GCC 12 and configures compiler environment variables across CI jobs |
Comments suppressed due to low confidence (1)
.github/workflows/ci.yml:161
- The NVCC_PREPEND_FLAGS in the supraseal job is missing the
-allow-unsupported-compilerflag that is present in the check job (line 53) and cgo-bindings job (line 118). This inconsistency could lead to different compilation behavior. Consider adding-allow-unsupported-compilerto maintain consistency:NVCC_PREPEND_FLAGS: \"-ccbin /usr/bin/g++-12 -allow-unsupported-compiler\"
NVCC_PREPEND_FLAGS: "-ccbin /usr/bin/g++-12"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
@snadrus : is there more context on this change (e.g., related issue, slack thread)? I assume the downgrade isn't intentional. I'll convert to draft for now, but please mark when it's ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.