chore(php): regenerate php-model seeds to pick up phpunit 12.5.22 bump#15171
Merged
davidkonigsberg merged 2 commits intomainfrom Apr 20, 2026
Merged
chore(php): regenerate php-model seeds to pick up phpunit 12.5.22 bump#15171davidkonigsberg merged 2 commits intomainfrom
davidkonigsberg merged 2 commits intomainfrom
Conversation
The base PhpProject already renders composer.json with phpunit/phpunit ^12.5.22 (addressing GHSA-qrr6-mg7r-m243), and the php-sdk seeds were regenerated in the 2.4.2 release. The php-model seeds were still stale at phpunit ^9.0, which is what Dependabot alert #1995 flagged. Regenerating the php-model fixtures against the current generator picks up: - phpunit/phpunit ^9.0 -> ^12.5.22 in composer.json - ci.yml php-version 8.1 -> 8.3 (minimum supported by PHPUnit 12) - updated .fern/metadata.json fields No generator code or seed files were hand-edited; all changes are produced by running pnpm seed test --generator php-model against the current base.
davidkonigsberg
approved these changes
Apr 20, 2026
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
devin-ai-integration bot
added a commit
that referenced
this pull request
Apr 20, 2026
Conflicts were all modify/delete: main regenerated seed/php-model/** fixture outputs (phpunit 12.5.22 bump, #15171) for a generator this branch disables and whose output tree was removed in #15097. Kept our deletion; the php-model workspace is retained as configuration only via its `seed.yml` with `disabled: true`. Co-Authored-By: David Konigsberg <davidakonigsberg@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Linear ticket: Refs
Resolves Dependabot alert #1995 — GHSA-qrr6-mg7r-m243 (PHPUnit argument injection via newline in PHP INI values forwarded to child processes).
Root cause. The generator source of truth (
generators/php/base/src/project/PhpProject.ts) already emitsphpunit/phpunit: ^12.5.22— that fix shipped inphp-sdk@2.4.2(seegenerators/php/sdk/changes/2.4.2/bump-phpunit-cve.yml), and the php-sdk seeds were regenerated at that time. The php-model seeds were not regenerated in that PR, so they still contained^9.0in the committedcomposer.jsonsnapshots. That's the stale file Dependabot is pointing at (seed/php-model/multi-url-environment-reference/composer.json).Fix. Per review feedback, the fix is at the generator level (already in place) + a regeneration of the php-model seed snapshots. No generator code or seed files were hand-edited; the seed diff is purely the output of running the current generator.
Changes Made
seed/php-model/*fixtures via:phpunit/phpunit: ^9.0→^12.5.22incomposer.json(resolves the alert)php-version: "8.1"→"8.3"in.github/workflows/ci.yml(minimum supported by PHPUnit 12; matches whatbump-phpunit-cve.ymlalready described for php-sdk).fern/metadata.json(originGitCommitIsDirty,invokedBy,requestedVersion,ciProvider) produced by the current generator.github/dependabot-alerts/alert-1995.mdNot included. Two orphan top-level
composer.jsonfiles remain inseed/php-sdk/basic-auth/andseed/php-sdk/basic-auth-pw-omitted/with^9.0. Those fixtures now only configure awire-testsoutput folder (whosecomposer.jsonis already on^12.5.22), so the top-level files are leftover output from a previous config and are not produced by the current generator. Leaving them for a separate cleanup PR to keep this one scoped to the alert.Testing
--skip-scripts; spot-checkedseed/php-model/multi-url-environment-reference/composer.jsonto confirmphpunit/phpunitis now^12.5.22; verified no remaining"phpunit/phpunit": "^9strings underseed/php-model/.Link to Devin session: https://app.devin.ai/sessions/ce52c98beed84f9394ee30be4afa1f13