chore(ci): re-enable php-model seed auto-update (GHSA-qrr6-mg7r-m243)#15158
Closed
github-actions[bot] wants to merge 2 commits intomainfrom
Closed
chore(ci): re-enable php-model seed auto-update (GHSA-qrr6-mg7r-m243)#15158github-actions[bot] wants to merge 2 commits intomainfrom
github-actions[bot] wants to merge 2 commits intomainfrom
Conversation
The php-model-seed-update job in update-seed.yml was pinned to if: false ('generator not actively supported'), so when #15145 bumped phpunit to ^12.5.22 and PHP to 8.3 in the shared @fern-api/php-base PhpProject template, the Update Seed auto-PR pipeline only refreshed seed/php-sdk/** — seed/php-model/** stayed on phpunit ^9.0 / PHP 8.1, leaving GHSA-qrr6-mg7r-m243 still flagged by Dependabot on seed/php-model/multi-url-environment-reference/composer.json.\n\nRestoring the original condition so the matching Update Seed auto-PR will run for php-model on the next push to main (or on a manual workflow_dispatch with language=php). The downstream apply-update-seed-patches / create-pull-request matrix already includes php-model, so no other changes are needed. Seed fixtures under seed/php-model/** will be refreshed by that follow-up auto-PR rather than by hand-edits in this PR.
c09c062 to
410f37a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Linear ticket: Refs Dependabot alert #1995
Addresses GHSA-qrr6-mg7r-m243 (HIGH): PHPUnit forwards PHP INI settings to child processes without neutralizing INI metacharacters, allowing argument injection via newlines in INI values. Patched in
phpunit/phpunit@12.5.22.The
php-model-seed-updatejob in.github/workflows/update-seed.ymlwas pinned toif: false("generator not actively supported"), so when the php SDK release 2.4.2 bumped phpunit to^12.5.22and PHP to8.3in the shared@fern-api/php-basePhpProjecttemplate, the Update Seed auto-PR pipeline only refreshedseed/php-sdk/**.seed/php-model/**stayed on phpunit^9.0/ PHP 8.1, leaving GHSA-qrr6-mg7r-m243 still flagged by Dependabot onseed/php-model/multi-url-environment-reference/composer.json.This PR restores the original
if:condition (matchingphp-sdk-seed-updateand the other generator jobs), so the matching Update Seed auto-PR will run for php-model on the next push tomain(or on a manualworkflow_dispatchwithlanguage=php). The downstreamapply-update-seed-patches/create-pull-requestmatrix already includesphp-model, so no other workflow changes are needed. The refreshedseed/php-model/**fixtures will land via the follow-up auto-PR rather than via hand-edits here.Changes Made
.github/workflows/update-seed.yml: re-enablephp-model-seed-updateby uncommenting the originalif:condition and removing theif: falseoverride.github/dependabot-alerts/alert-1995.mdscaffold per the PR instructionsTesting
diffof the restoredif:block againstphp-sdk-seed-updateconfirms they match exactlycc @davidkonigsberg
Link to Devin session: https://app.devin.ai/sessions/c54f0fbc02ea496dadad26385b98f64d