Skip to content

fix(build): unblock eslint-plugin-react-hooks Rollup bundle#36311

Open
ViperDroid wants to merge 2 commits intofacebook:mainfrom
ViperDroid:fix/build-scripts
Open

fix(build): unblock eslint-plugin-react-hooks Rollup bundle#36311
ViperDroid wants to merge 2 commits intofacebook:mainfrom
ViperDroid:fix/build-scripts

Conversation

@ViperDroid
Copy link
Copy Markdown

@ViperDroid ViperDroid commented Apr 17, 2026

  • Add @types/babel__code-frame so @rollup/plugin-typescript can typecheck imports of @babel/code-frame during the monorepo build.
  • Honor bundle.preferBuiltins in @rollup/plugin-node-resolve so Node built-ins (e.g. tty, os) resolve correctly for the hooks ESLint plugin; bundles.js already sets preferBuiltins: true for that package.

Made-with: Viper Droid

Summary

How did you test this change?

@meta-cla
Copy link
Copy Markdown

meta-cla bot commented Apr 17, 2026

Hi @ViperDroid!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

- Add @types/babel__code-frame so @rollup/plugin-typescript can typecheck
  imports of @babel/code-frame during the monorepo build.
- Honor bundle.preferBuiltins in @rollup/plugin-node-resolve so Node
  built-ins (e.g. tty, os) resolve correctly for the hooks ESLint plugin;
  bundles.js already sets preferBuiltins: true for that package.
@meta-cla meta-cla bot added the CLA Signed label Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant