Conversation
Agent-Logs-Url: https://github.com/fabiocaccamo/django-admin-interface/sessions/22137723-dc30-49e9-8976-5e1074528d6f Co-authored-by: fabiocaccamo <1035294+fabiocaccamo@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #481 +/- ##
=======================================
Coverage 97.48% 97.48%
=======================================
Files 40 40
Lines 438 438
=======================================
Hits 427 427
Misses 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s declared and tested compatibility targets to drop Django 4.0 and 4.1, making Django 4.2 (LTS) the new minimum supported version across dev requirements, tox, and CI.
Changes:
- Removed Django 4.0/4.1 tox environments and dependency factors.
- Bumped
requirements.txtminimum Django version to>= 4.2. - Updated packaging classifiers and CI test matrix to stop advertising/testing Django 4.0/4.1.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tox.ini |
Drops dj40/dj41 envs and their pinned deps from the tox matrix. |
requirements.txt |
Raises the minimum Django version for installed requirements to 4.2+. |
pyproject.toml |
Removes Django 4.0/4.1 trove classifiers to match the new support policy. |
.github/workflows/test-package.yml |
Removes Django 4.0/4.1 from the GitHub Actions test matrix. |
Comments suppressed due to low confidence (1)
pyproject.toml:29
- PR description says Django 4.2 is the minimum supported version, but the package metadata still does not declare a Django dependency (only django-colorfield). As a result, pip can install this project alongside Django 4.0/4.1 without any resolver error, which doesn’t match the stated support policy. Consider adding a
Django >= 4.2requirement to[project].dependencies(or an appropriate extra) so the minimum version is enforced at install time, not only in CI/tox/requirements.txt.
classifiers = [
"Development Status :: 5 - Production/Stable",
"Environment :: Web Environment",
"Framework :: Django",
"Framework :: Django :: 4.2",
"Framework :: Django :: 5.0",
"Framework :: Django :: 5.1",
"Framework :: Django :: 5.2",
"Framework :: Django :: 6.0",
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Removes support for Django 4.0 and 4.1, setting 4.2 (LTS) as the minimum supported version.
Changes
pyproject.toml: removeFramework :: Django :: 4.0and4.1classifiersrequirements.txt: bump minimum Django from>= 2.2to>= 4.2tox.ini: dropdj40/dj41envs and their deps; remove from envlist combinations.github/workflows/test-package.yml: remove Django 4.0/4.1 from the CI test matrixChecklist before requesting a review