Skip to content

Refactory and code style fixes#85

Merged
everoddandeven merged 1 commit intomainfrom
refactory-and-fixes
Apr 22, 2026
Merged

Refactory and code style fixes#85
everoddandeven merged 1 commit intomainfrom
refactory-and-fixes

Conversation

@everoddandeven
Copy link
Copy Markdown
Owner

@everoddandeven everoddandeven commented Apr 20, 2026

  • Refactory common, daemon and wallet data model
  • Refactory tests code
  • Set monero-cpp code style for cpp code
  • Remove unused code
  • Check response status on daemon rpc calls
  • Add copyright to files
  • Add MTRACE, MWARNING logging

@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented Apr 20, 2026

Not up to standards ⛔

🔴 Issues 50 medium

Alerts:
⚠ 50 issues (≤ 0 issues of at least minor severity)

Results:
50 new issues

Category Results
Complexity 50 medium

View in Codacy

🟢 Metrics -37 complexity · 7 duplication

Metric Results
Complexity -37
Duplication 7

View in Codacy

🟢 Coverage 90.27% diff coverage · +0.56% coverage variation

Metric Results
Coverage variation +0.56% coverage variation (-1.00%)
Diff coverage 90.27% diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (c9dde87) 17578 15689 89.25%
Head commit (a19114b) 17556 (-22) 15767 (+78) 89.81% (+0.56%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#85) 3103 2801 90.27%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes. Give us feedback

@everoddandeven everoddandeven force-pushed the refactory-and-fixes branch 4 times, most recently from 4fb63e9 to 6c0263c Compare April 21, 2026 23:27
* Refactory common, daemon and wallet data model
* Refactory tests code
* Set monero-cpp code style for cpp code
* Remove unused code
* Check response status on daemon rpc calls
* Add copyright to files
* Add MTRACE, MWARNING logging
@everoddandeven everoddandeven merged commit 33253e9 into main Apr 22, 2026
6 checks passed
@everoddandeven everoddandeven deleted the refactory-and-fixes branch April 22, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant