ci: add type tests for TypeScript 5.x to CI workflow#230
Merged
lumirlumir merged 4 commits intomainfrom Apr 21, 2026
Merged
Conversation
fasttime
commented
Apr 14, 2026
Member
Author
There was a problem hiding this comment.
GitHub marks the comments in this file in red because it doesn't recognize tsconfig.dist.json as a TypeScript config file, so it falls back to plain JSON instead of JSONC. The syntax highlighting disappears if the file is renamed to dist.tsconfig.json, although that would not align with our conventions.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds additional CI coverage to ensure the published dist/ type definitions remain compatible with TypeScript 5.x (in addition to the existing TypeScript 6.x type tests).
Changes:
- Add a dedicated TS config for checking only
dist/with older TypeScript versions. - Extend CI workflow to run
tscagainstdist/using TypeScript 5.3 and latest 5.x vianpx. - Update ESLint flat config so
tsconfig*.jsonfiles are linted as JSONC (to allow comments/trailing commas).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
tests/types/tsconfig.dist.json |
New TS config intended for running tsc checks on dist/ under TS 5.x. |
eslint.config.js |
Lints tsconfig*.json as JSONC and enables trailing commas support. |
.github/workflows/ci.yml |
Adds CI steps to run TS 5.3 and 5.x tsc checks against dist/. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lumirlumir
requested changes
Apr 18, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This was referenced Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
AI acknowledgment
What is the purpose of this pull request?
add tests in CI
What changes did you make? (Give an overview)
Add type tests for TypeScript v5.3 and v.5.x besides existing tests targeting TypeScript v6.0.
Related Issues
refs #224
Is there anything you'd like reviewers to focus on?