Skip to content

ci: add type tests for TypeScript 5.x to CI workflow#230

Merged
lumirlumir merged 4 commits intomainfrom
ts-5-type-tests
Apr 21, 2026
Merged

ci: add type tests for TypeScript 5.x to CI workflow#230
lumirlumir merged 4 commits intomainfrom
ts-5-type-tests

Conversation

@fasttime
Copy link
Copy Markdown
Member

Prerequisites checklist

AI acknowledgment

  • I did not use AI to generate this PR.
  • (If the above is not checked) I have reviewed the AI-generated content before submitting.

What is the purpose of this pull request?

add tests in CI

What changes did you make? (Give an overview)

Add type tests for TypeScript v5.3 and v.5.x besides existing tests targeting TypeScript v6.0.

Related Issues

refs #224

Is there anything you'd like reviewers to focus on?

@eslintbot eslintbot added this to Triage Apr 14, 2026
@github-project-automation github-project-automation Bot moved this to Needs Triage in Triage Apr 14, 2026
Copy link
Copy Markdown
Member Author

@fasttime fasttime Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub marks the comments in this file in red because it doesn't recognize tsconfig.dist.json as a TypeScript config file, so it falls back to plain JSON instead of JSONC. The syntax highlighting disappears if the file is renamed to dist.tsconfig.json, although that would not align with our conventions.

@fasttime fasttime marked this pull request as ready for review April 15, 2026 07:43
@lumirlumir lumirlumir moved this from Needs Triage to Triaging in Triage Apr 18, 2026
@lumirlumir lumirlumir requested a review from Copilot April 18, 2026 07:45
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds additional CI coverage to ensure the published dist/ type definitions remain compatible with TypeScript 5.x (in addition to the existing TypeScript 6.x type tests).

Changes:

  • Add a dedicated TS config for checking only dist/ with older TypeScript versions.
  • Extend CI workflow to run tsc against dist/ using TypeScript 5.3 and latest 5.x via npx.
  • Update ESLint flat config so tsconfig*.json files are linted as JSONC (to allow comments/trailing commas).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
tests/types/tsconfig.dist.json New TS config intended for running tsc checks on dist/ under TS 5.x.
eslint.config.js Lints tsconfig*.json as JSONC and enables trailing commas support.
.github/workflows/ci.yml Adds CI steps to run TS 5.3 and 5.x tsc checks against dist/.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/types/tsconfig.legacy.json
Comment thread tests/types/tsconfig.dist.json Outdated
Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
Comment thread tests/types/tsconfig.dist.json Outdated
@lumirlumir lumirlumir moved this from Triaging to Implementing in Triage Apr 18, 2026
fasttime and others added 2 commits April 18, 2026 17:36
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Member

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lumirlumir lumirlumir merged commit 252f7db into main Apr 21, 2026
33 checks passed
@lumirlumir lumirlumir deleted the ts-5-type-tests branch April 21, 2026 10:58
@github-project-automation github-project-automation Bot moved this from Implementing to Complete in Triage Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

4 participants