Skip to content

Consolidate flake8 configuration into pyproject.toml #9957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
p-r-a-v-i-n wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −4
Open

Consolidate flake8 configuration into pyproject.toml #9957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ repos:
hooks:
- id: flake8
additional_dependencies:
- flake8-pyproject
Copy link
Copy Markdown
Contributor Author

@p-r-a-v-i-n p-r-a-v-i-n Apr 15, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't know if we are ok with adding this ( flake8-pyproject ) extra dependency in pre-commit which requires here to load flake8 config from pyproject.toml

- flake8-tidy-imports
- flake8-bugbear
- repo: https://github.com/adamchainz/blacken-docs
Expand Down
5 changes: 5 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,11 @@ extra_standard_library = [ "types" ]
known_third_party = [ "pytest", "_pytest", "django", "pytz", "uritemplate" ]
known_first_party = [ "rest_framework", "tests" ]

[tool.flake8]
extend-ignore = [ "E501", "W503", "W504", "B" ]
extend-select = [ "B006" ]
banned-modules = "json = use from rest_framework.utils import json!"

[tool.codespell]
# Ref: https://github.com/codespell-project/codespell#using-a-config-file
skip = "*/kickstarter-announcement.md,*.js,*.map,*.po,*.css,locale"
Expand Down
4 changes: 0 additions & 4 deletions setup.cfg
View file
Open in desktop

This file was deleted.

Loading