Draft
Conversation
danirabbit
requested changes
Dec 18, 2025
Member
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
Mostly good, just one comment
| }; | ||
|
|
||
| var grid = new Gtk.Grid () { | ||
| column_spacing = 6 |
Member
There was a problem hiding this comment.
I think we need to also adjust this and there's significant changes to padding here:
BEFORE
AFTER
Member
Author
There was a problem hiding this comment.
I guess the cause of the unwanted margins are due to Granite.HeaderLabel itself, not the grid here, so maybe we need to fix this in Granite?
Member
Author
|
Converting to draft because this needs fixes in Granite first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacing STYLE_CLASS_RICH_LIST with Granite.ListItem would be done in another PR because I suppose it requires more changes.
Requires elementary/granite#936 (stable CI is failing because this change in granite is not released yet)