releng: add legacy product for 2024-12 build#268
releng: add legacy product for 2024-12 build#268arfio wants to merge 1 commit intoeclipse-tracecompass-incubator:masterfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds a new Eclipse PDE product descriptor Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
rcp/org.eclipse.tracecompass.incubator.rcp.product/legacy-e4.34/tracing.incubator.product (2)
138-170: Remove duplicateorg.eclipse.tracecompass.tmf.clifeature declaration.Line 138 and Line 170 declare the same feature; keep the
installMode="root"declaration only to avoid redundant configuration.♻️ Proposed cleanup
- <feature id="org.eclipse.tracecompass.tmf.cli"/> ... <feature id="org.eclipse.tracecompass.tmf.cli" installMode="root"/>🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@rcp/org.eclipse.tracecompass.incubator.rcp.product/legacy-e4.34/tracing.incubator.product` around lines 138 - 170, The product file includes a duplicate feature declaration for org.eclipse.tracecompass.tmf.cli; remove the earlier plain <feature id="org.eclipse.tracecompass.tmf.cli"/> entry and keep only the later declaration that includes installMode="root" (the <feature id="org.eclipse.tracecompass.tmf.cli" installMode="root"/>), ensuring no other duplicate feature ids remain.
32-57: Update Solaris VM entry to match Java 17 baseline across all platforms.Line 56 references
JavaSE-1.8while lines 32/34/36/54/55/57 enforce Java 17. Even thoughinclude="false"disables this entry, the stale baseline creates maintenance confusion and increases regression risk. This inconsistency appears inrcp/org.eclipse.tracecompass.incubator.rcp.product/legacy-e4.34/tracing.incubator.productand the main product file.Update Solaris entries to
JavaSE-17to align with the project's Java baseline.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@rcp/org.eclipse.tracecompass.incubator.rcp.product/legacy-e4.34/tracing.incubator.product` around lines 32 - 57, The Solaris VM entry in the <vm> block currently uses the old Java runtime identifier "JavaSE-1.8"; update the Solaris element value to "org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-17" so the <solaris ...> entry matches the other platform entries (linux/macos/windows) and the project's Java 17 baseline.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@rcp/org.eclipse.tracecompass.incubator.rcp.product/legacy-e4.34/tracing.incubator.product`:
- Around line 190-193: The repository entries under the <repositories> element
use insecure, moving-target URLs (location="http://.../master/..."); update both
<repository> location attributes to use HTTPS and replace the "master" path with
the exact 2024-12 release repository paths your releng pipeline uses so the
entries become release-pinned and secure (modify the two <repository> elements
shown in the diff).
---
Nitpick comments:
In
`@rcp/org.eclipse.tracecompass.incubator.rcp.product/legacy-e4.34/tracing.incubator.product`:
- Around line 138-170: The product file includes a duplicate feature declaration
for org.eclipse.tracecompass.tmf.cli; remove the earlier plain <feature
id="org.eclipse.tracecompass.tmf.cli"/> entry and keep only the later
declaration that includes installMode="root" (the <feature
id="org.eclipse.tracecompass.tmf.cli" installMode="root"/>), ensuring no other
duplicate feature ids remain.
- Around line 32-57: The Solaris VM entry in the <vm> block currently uses the
old Java runtime identifier "JavaSE-1.8"; update the Solaris element value to
"org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-17"
so the <solaris ...> entry matches the other platform entries
(linux/macos/windows) and the project's Java 17 baseline.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: b9900d9c-48cb-470b-8fb6-26634dd27c4a
📒 Files selected for processing (1)
rcp/org.eclipse.tracecompass.incubator.rcp.product/legacy-e4.34/tracing.incubator.product
| <repositories> | ||
| <repository location="http://download.eclipse.org/tracecompass/master/rcp-repository" name="" enabled="true" /> | ||
| <repository location="http://download.eclipse.org/tracecompass.incubator/master/repository" name="" enabled="true" /> | ||
| </repositories> |
There was a problem hiding this comment.
Use HTTPS and pin repositories to a release-specific location.
Line 191 and Line 192 currently point to http://.../master/.... For a legacy 2024-12 build, this is both insecure (MITM risk) and non-reproducible (moving target).
🔧 Proposed fix
- <repository location="http://download.eclipse.org/tracecompass/master/rcp-repository" name="" enabled="true" />
- <repository location="http://download.eclipse.org/tracecompass.incubator/master/repository" name="" enabled="true" />
+ <repository location="https://download.eclipse.org/tracecompass/<release-train>/rcp-repository" name="" enabled="true" />
+ <repository location="https://download.eclipse.org/tracecompass.incubator/<release-train>/repository" name="" enabled="true" />Use the exact 2024-12 path your releng pipeline already consumes.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@rcp/org.eclipse.tracecompass.incubator.rcp.product/legacy-e4.34/tracing.incubator.product`
around lines 190 - 193, The repository entries under the <repositories> element
use insecure, moving-target URLs (location="http://.../master/..."); update both
<repository> location attributes to use HTTPS and replace the "master" path with
the exact 2024-12 release repository paths your releng pipeline uses so the
entries become release-pinned and secure (modify the two <repository> elements
shown in the diff).
Signed-off-by: Arnaud Fiorini <fiorini.arnaud@gmail.com>
1 participant
What it does
releng: add legacy product that was modified in PR #267.
How to test
Run the build with legacy product
Follow-ups
N/A
Review checklist
Summary by CodeRabbit