Skip to content

callstack: Add case to handle nestable instant events#257

Merged
arfio merged 1 commit intoeclipse-tracecompass-incubator:masterfrom
theibhir:markers-nestable-instant
Apr 22, 2026
Merged

callstack: Add case to handle nestable instant events#257
arfio merged 1 commit intoeclipse-tracecompass-incubator:masterfrom
theibhir:markers-nestable-instant

Conversation

@theibhir
Copy link
Copy Markdown
Contributor

What it does

Show markers for nestable instant events

How to test

  • run the incubator
  • load the following trace:

{
"traceEvents": [
{
"name": "HandleRequest",
"cat": "server",
"ph": "B",
"ts": 1000000,
"pid": 1,
"tid": 10,
"args": {
"endpoint": "/api/user"
}
},
{
"name": "ParseJSON",
"cat": "server",
"ph": "B",
"ts": 1000100,
"pid": 1,
"tid": 10
},
{
"name": "json_parse_step",
"cat": "parser",
"ph": "n",
"ts": 1000120,
"pid": 1,
"tid": 10,
"id": "0xabc",
"args": {
"key": "user_id",
"value_type": "string"
}
},
{
"name": "ParseJSON",
"cat": "server",
"ph": "E",
"ts": 1000300,
"pid": 1,
"tid": 10
},
{
"name": "QueryDatabase",
"cat": "database",
"ph": "B",
"ts": 1000400,
"pid": 1,
"tid": 10,
"args": {
"query": "SELECT * FROM users WHERE id=?"
}
},
{
"name": "QueryDatabase",
"cat": "database",
"ph": "E",
"ts": 1000800,
"pid": 1,
"tid": 10
},
{
"name": "HandleRequest",
"cat": "server",
"ph": "E",
"ts": 1001000,
"pid": 1,
"tid": 10
}
]

}

Follow-ups

Review checklist

  • As an author, I have thoroughly tested my changes and carefully followed the instructions in this template

display markers for nested events

Signed-off-by: Yassine Ibhir <yassine.ibhir.ibhir@ericsson.com>
@theibhir theibhir force-pushed the markers-nestable-instant branch from 78e924a to 6e2fc5f Compare November 14, 2025 15:45
@theibhir theibhir changed the title add case to handle nestable instant events callstack: Add case to handle nestable instant events Nov 14, 2025
@MatthewKhouzam MatthewKhouzam requested a review from arfio November 29, 2025 00:44
@arfio arfio merged commit b626f3c into eclipse-tracecompass-incubator:master Apr 22, 2026
2 checks passed
@arfio
Copy link
Copy Markdown
Contributor

arfio commented Apr 22, 2026

Thank you for the PR, I reviewed and approve the changes (even though I forgot to press review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants