server: Add support for generic data endpoint#250
Open
PatrickTasse wants to merge 1 commit intoeclipse-tracecompass-incubator:masterfrom
Open
server: Add support for generic data endpoint#250PatrickTasse wants to merge 1 commit intoeclipse-tracecompass-incubator:masterfrom
PatrickTasse wants to merge 1 commit intoeclipse-tracecompass-incubator:masterfrom
Conversation
Add support for the /obj endpoint for implementations of IObjectDataProvider. Add selectionRange to DataProviderCapabilities serializer. Do not serialize capabilities that are false by default. Update swagger annotations accordingly. Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
| */ | ||
| enum ProviderType { | ||
| TABLE, TREE_TIME_XY, TIME_GRAPH, DATA_TREE, NONE, GANTT_CHART, TREE_GENERIC_XY | ||
| TABLE, TREE_TIME_XY, TIME_GRAPH, DATA_TREE, GANTT_CHART, TREE_GENERIC_XY, DATA, NONE |
Contributor
There was a problem hiding this comment.
I think this breaks API
bhufmann
reviewed
Oct 28, 2025
Contributor
bhufmann
left a comment
bhufmann
left a comment
There was a problem hiding this comment.
It would be good to generate the new API.yaml file, use it to generate the TSP java client used for API testing and add some unit tests to test the new server endpoints. With this it can be verified that the server implementation complies with the TSP specification and clients can query the back-end with just using the specification without know the BE implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Add support for the /obj endpoint for implementations of IObjectDataProvider.
Add selectionRange to DataProviderCapabilities serializer. Do not serialize capabilities that are false by default.
Update swagger annotations accordingly.
How to test
Test new /obj endpoint
Follow-ups
N/A
Review checklist