InAndOutDataProviderFactory extends AbstractTmfDataProviderConfigurator#167
Draft
frallax wants to merge 6 commits intoeclipse-tracecompass-incubator:masterfrom
Draft
InAndOutDataProviderFactory extends AbstractTmfDataProviderConfigurator#167frallax wants to merge 6 commits intoeclipse-tracecompass-incubator:masterfrom
frallax wants to merge 6 commits intoeclipse-tracecompass-incubator:masterfrom
Conversation
1 task
Contributor
Author
|
NOTES:
|
bhufmann
requested changes
Mar 21, 2025
Contributor
bhufmann
left a comment
bhufmann
left a comment
There was a problem hiding this comment.
Thanks for the contribution. I added some comments,
| * the trace to apply it to | ||
| * @param writeConfig | ||
| * write the config (do only once) | ||
| * @return InAndOutAnalysisModule |
| * @throws TmfConfigurationException | ||
| * if an error occurs | ||
| */ | ||
| private void create(@NonNull ITmfConfiguration config, @NonNull ITmfTrace trace, boolean writeConfig, IAnalysisModule module) throws TmfConfigurationException { |
Contributor
There was a problem hiding this comment.
the class is NonNullByDefault, so you can remove the null annotations from the method parameters
Make create private
frallax
force-pushed
the
frallax-config-refactor
branch
from
9c744a5 to
fa57b5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Refactor the InAndOutDataProviderFactory to use the proposed api for configurable data provider factories in org.eclipse.tracecompass PR 235.
Benefit that I think this PR introduces:
How to test
Test will be added if the proposal is accepted.
Checkout org.eclipse.tracecompass PR 235 and incubator PR. Then try to use the InAndOutDataProviderFactory as usual (e.g. by using the tsp-python-client). Can add more explicit instructions if needed.
Follow-ups
Depending on the discussions around this proposal, add documentation on how one can create a new configurable data provider factory using the proposed API.
Review checklist