Adding perfetto support for TC#155
Open
ammarwa wants to merge 1 commit intoeclipse-tracecompass-incubator:masterfrom
Open
Adding perfetto support for TC#155ammarwa wants to merge 1 commit intoeclipse-tracecompass-incubator:masterfrom
ammarwa wants to merge 1 commit intoeclipse-tracecompass-incubator:masterfrom
Conversation
arfio
requested changes
May 9, 2025
Contributor
arfio
left a comment
There was a problem hiding this comment.
This allows Trace Compass to support another trace format, great work!
There is one additional thing, the com.google.protobuf package should be added to trace compass target in common/org.eclipse.tracecompass.incubator.target/tracecompass-incubator-master.target.
Something like this:
<location includeDependencyDepth="none" includeSource="true" missingManifest="generate" type="Maven">
<dependencies>
<dependency>
<groupId>com.google.protobuf</groupId>
<artifactId>protobuf-java</artifactId>
<version>4.29.3</version>
<type>jar</type>
</dependency>
</dependencies>
</location>
Contributor
There was a problem hiding this comment.
This file should be moved to src/org/eclipse/tracecompass/incubator/perfetto/core/tests/PerfettoTest.java to match the package name
Contributor
There was a problem hiding this comment.
This file and all the other source files for this plugin should be moved from src/org/eclipse/tracecompass/internal/perfetto/core to src/org/eclipse/tracecompass/incubator/internal/perfetto/core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
The Perfetto trace format is being used today for many profiling and tracing tools, such as rocprofv3 for AMD GPUs profiling and tracing, Android traces, and Chrome traces.
This PR adds Protobuf (Perfetto format precisely) support for TraceCompass to visualize traces that can be visualized using Perfetto UI.
How to test
Provided binary trace output file that will be used in the tests to read that trace and ensure we can analyze it correctly.
Follow-ups
More work must be done to make it efficient and optimized for reading protobuf traces. Also, more work needs to be done to add more visualization that can match the needs of the traces that use the Perfetto format. Also, more work is required on testing and validation.
Review checklist