Identifier jvm info#126
Open
MatthewKhouzam wants to merge 5 commits intoeclipse-tracecompass-incubator:masterfrom
Open
Identifier jvm info#126MatthewKhouzam wants to merge 5 commits intoeclipse-tracecompass-incubator:masterfrom
MatthewKhouzam wants to merge 5 commits intoeclipse-tracecompass-incubator:masterfrom
Conversation
The rest.core plug-in version is retrieved to show in the identifier service. This is the only way to retrieve the version programmatically and hence the plug-in version and release version has to match. Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
The rest.core plug-in version is retrieved to show in the identifier service. This is the only way to retrieve the version programmatically and hence the plug-in version and release version has to match. Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
fixes eclipse-tracecompass-incubator#121 Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
bhufmann
requested changes
Nov 22, 2024
Contributor
bhufmann
left a comment
bhufmann
left a comment
There was a problem hiding this comment.
wrong branch. Please provide the identifier changes on top of latest in master branch.
Use CDT's cppFilt to demange c++ names if available. Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
MatthewKhouzam
force-pushed
the
identifier-jvm
branch
from
1a79fbe to
00da834
Compare
Can help for diagnosis/debugging [Added] JVM version to identifier service Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
MatthewKhouzam
force-pushed
the
identifier-jvm
branch
from
00da834 to
08937a0
Compare
Contributor
Author
Fixed. |
bhufmann
requested changes
Dec 3, 2024
Contributor
bhufmann
left a comment
bhufmann
left a comment
There was a problem hiding this comment.
It looks like that it contains commits that are already merged, as well it's looks like it's based on stable-10.2 branch instead of master. Could you please rebase it on recent master?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.