Read splash shell title directly from the product in IDEApplication#3923
Open
vogella wants to merge 1 commit intoeclipse-platform:masterfrom
Open
Read splash shell title directly from the product in IDEApplication#3923vogella wants to merge 1 commit intoeclipse-platform:masterfrom
vogella wants to merge 1 commit intoeclipse-platform:masterfrom
Conversation
IDEApplication.start set the splash shell's taskbar title via ChooseWorkspaceDialog.getWindowTitle(). That helper is scoped to the workspace chooser dialog: it returns Platform.getProduct().getName(), and falls back to an IDEWorkbenchMessages string whose name (ChooseWorkspaceDialog_defaultProductName) is tied to the chooser dialog's presentation. Using it for the splash shell is a layering inversion. The splash is a property of the application, not of the chooser dialog, and the dialog-specific NLS fallback is not appropriate for the splash taskbar entry. Read Platform.getProduct().getName() directly in IDEApplication. If no product is configured, leave the launcher's default title in place rather than substituting a chooser-dialog placeholder. ChooseWorkspaceDialog.getWindowTitle() is retained as an internal helper for the dialog itself. No user-visible change for Eclipse IDE products, which always have a product name configured.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates IDEApplication startup behavior so the splash shell’s taskbar title is sourced directly from the configured Eclipse product (when present), avoiding reuse of the workspace chooser dialog’s UI-specific fallback.
Changes:
- Set splash shell taskbar title from
Platform.getProduct().getName()when a product is configured. - Preserve the launcher-provided default splash title when no product is configured (instead of using the chooser dialog’s placeholder).
- Keep the splash shell icon assignment via
Window.getDefaultImages().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
@vogella: What kind of problem do you want to solve with this PR? Can you pls. explain? |
Contributor
Author
|
The splash shell is owned by the application, not the chooser dialog, and the dialog's NLS fallback is not appropriate for a splash taskbar entry. It also triggers unnecessary class loading even if the dialog is not shown, like in a restart |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IDEApplication.startusedChooseWorkspaceDialog.getWindowTitle()to set the splash shell's taskbar title. That helper belongs to the workspace chooser dialog: it returnsPlatform.getProduct().getName()with a fallback toIDEWorkbenchMessages.ChooseWorkspaceDialog_defaultProductName, an NLS string tied to the chooser dialog's presentation.The splash shell is owned by the application, not the chooser dialog, and the dialog's NLS fallback is not appropriate for a splash taskbar entry. This change reads the product name directly in
IDEApplication. When no product is configured, the launcher's default title is kept.ChooseWorkspaceDialog.getWindowTitle()is kept for use inside the chooser dialog itself.Behavior
For Eclipse IDE products, which always have a product name, the taskbar text on the splash shell is unchanged. For applications without a configured product, the launcher's default title is preserved instead of being replaced by a chooser-dialog placeholder.
Test plan
ChooseWorkspaceDialog.getWindowTitle()internally).