Skip to content

Support new SWT dirty indicator in StackRenderer#3823

Open
vogella wants to merge 1 commit intoeclipse-platform:masterfrom
vogella:feature/new-dirty-indicator
Open

Support new SWT dirty indicator in StackRenderer#3823
vogella wants to merge 1 commit intoeclipse-platform:masterfrom
vogella:feature/new-dirty-indicator

Conversation

@vogella
Copy link
Copy Markdown
Contributor

@vogella vogella commented Mar 26, 2026

This change enables the new bullet-style dirty indicator for tabs in StackRenderer, which overlays the close button.

It implements the following:

  • Added a preference to enable this functionality in the Views preference page.
  • StackRenderer now calls setDirtyIndicatorStyle at the folder level.
  • setShowDirty is called on individual tab items when dirty state changes.
  • Preference changes at runtime are handled, updating all visible stacks.
  • Traditional '*' prefix is skipped when the new bullet-style indicator is active.

This PR works with the changes introduced in eclipse-platform/eclipse.platform.swt#3141.

@eclipse-platform-bot
Copy link
Copy Markdown
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.e4.ui.css.swt/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 58236dd691ffc0178d51d28c4e1f499602d7ce9c Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Thu, 26 Mar 2026 18:27:23 +0000
Subject: [PATCH] Version bump(s) for 4.40 stream


diff --git a/bundles/org.eclipse.e4.ui.css.swt/META-INF/MANIFEST.MF b/bundles/org.eclipse.e4.ui.css.swt/META-INF/MANIFEST.MF
index 01e69485e3..dcdb5e262b 100644
--- a/bundles/org.eclipse.e4.ui.css.swt/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.e4.ui.css.swt/META-INF/MANIFEST.MF
@@ -1,7 +1,7 @@
 Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-SymbolicName: org.eclipse.e4.ui.css.swt;singleton:=true
-Bundle-Version: 0.16.0.qualifier
+Bundle-Version: 0.16.100.qualifier
 Bundle-Name: %pluginName
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
-- 
2.53.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 26, 2026

Test Results

   852 files  ±0     852 suites  ±0   54m 55s ⏱️ - 1m 4s
 7 899 tests ±0   7 656 ✅ ±0  243 💤 ±0  0 ❌ ±0 
20 199 runs  ±0  19 544 ✅ ±0  655 💤 ±0  0 ❌ ±0 

Results for commit fe1a1b4. ± Comparison against base commit dceb45a.

♻️ This comment has been updated with latest results.

@vogella vogella force-pushed the feature/new-dirty-indicator branch 2 times, most recently from 4c0f977 to 7b0d4db Compare April 17, 2026 04:16
@vogella vogella marked this pull request as ready for review April 17, 2026 06:04
@vogella vogella force-pushed the feature/new-dirty-indicator branch from 7b0d4db to 72c6e7e Compare April 18, 2026 19:49
@merks
Copy link
Copy Markdown
Contributor

merks commented Apr 18, 2026

Is it intentional that this PR includes 2 commits one of which is about rounded corners? It's kind of confusing...

@vogella vogella force-pushed the feature/new-dirty-indicator branch from 72c6e7e to 598f07e Compare April 19, 2026 05:21
Adds a preference to enable the new bullet-style dirty indicator for
tabs,
which overlays the close button.

- StackRenderer now calls setDirtyIndicatorStyle on CTabFolder level.
- CTabItem.setShowDirty is updated on individual items.
- Preference change at runtime is handled to update all visible stacks.
- Asterisk prefix is skipped if the new indicator is enabled.
- Reflection is used for the new SWT methods for compatibility.

Fixes eclipse-platform#2568
@vogella vogella force-pushed the feature/new-dirty-indicator branch from 598f07e to fe1a1b4 Compare April 20, 2026 13:43
@vogella
Copy link
Copy Markdown
Contributor Author

vogella commented Apr 20, 2026

Is it intentional that this PR includes 2 commits one of which is about rounded corners? It's kind of confusing...

fixed

@vogella
Copy link
Copy Markdown
Contributor Author

vogella commented Apr 20, 2026

@schneidermic0 any feedback here? Can you help with testing this change?

@vogella
Copy link
Copy Markdown
Contributor Author

vogella commented Apr 21, 2026

I used this with a local build and it looks good.

image

Needs to be activated for now, maybe we want to change the default later.

image

@vogella
Copy link
Copy Markdown
Contributor Author

vogella commented Apr 21, 2026

Light theme (with hover over close)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants