Update thread_queue.h to remove conflict with windows headers#545
Open
mcgi5sr2 wants to merge 1 commit intoeclipse-paho:developfrom
Open
Update thread_queue.h to remove conflict with windows headers#545mcgi5sr2 wants to merge 1 commit intoeclipse-paho:developfrom
mcgi5sr2 wants to merge 1 commit intoeclipse-paho:developfrom
Conversation
Add parenthesis around MAX_CAPACITY evaluation to ensure it is not misinterpreted as a macro when using windows headers
Contributor
|
What is this colliding with? A |
Author
|
yes exactly that |
Author
|
Apologies I have been hard at another project. The issue is given by VS studio as a warning: followed by errors
To reproduce I think it should be enough to include curl/curl.h in your simple subscriber example. I get the PR isn't a tidy resolution but it seemed to be the simplest. |
Contributor
|
No worries; I'm busy on something else as well, but I will look into it as soon as I can. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add parenthesis around MAX_CAPACITY evaluation to ensure it is not misinterpreted as a macro when using windows headers
First came across this when trying to compile with libcurl headers (curl/curl.h).