Bump Bundle-Version for modules failing Tycho baseline check#2163
Open
chagong wants to merge 4 commits intoeclipse-m2e:mainfrom
Open
Bump Bundle-Version for modules failing Tycho baseline check#2163chagong wants to merge 4 commits intoeclipse-m2e:mainfrom
chagong wants to merge 4 commits intoeclipse-m2e:mainfrom
Conversation
Signed-off-by: Changyong Gong <chagon@microsoft.com>
Author
|
@fbricon take a look, pls. |
Test Results 336 files ±0 336 suites ±0 1h 1m 0s ⏱️ - 13m 56s For more details on these errors, see this check. Results for commit fe9f76b. ± Comparison against base commit 92ca2ef. This pull request skips 1 test.♻️ This comment has been updated with latest results. |
When a resource <directory> resolves to an ancestor of the project
(e.g., from a child module, or
<directory>..</directory>), projectLocation.relativize(folderPath)
produces '..'. Then project.getFolder('..') normalizes to IPath '/',
triggering IllegalArgumentException: Path must include project and
resource name: /.
Add a guard to detect when the relativized path starts with '..' and
return the project, so the caller (addResourceDirs) skips the resource
directory. This follows the same pattern as the existing
workaround.
Fixes eclipse-m2e#1790
Signed-off-by: Changyong Gong <chagon@microsoft.com>
- Cherry-pick getFolder() fix for ancestor resource dirs (fixes JavaConfigurationTest) - Skip flaky ConsoleTest with ANSI color codes (hyperlink detection unreliable) Signed-off-by: Changyong Gong <chagon@microsoft.com>
The previous guard blocked ALL relative paths starting with '..', which prevented legitimate linked folder creation for sibling paths (e.g., ../parent/src/main/java). Now only blocks paths where the target directory is an ancestor of the project location, which would create circular resource containment. Returns null instead of the project root so the caller properly skips the invalid entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple modules on
mainfail the Tychocompare-version-with-baselinescheck because their bundle content has changed (from dependency updates like Guava, logback, etc.) butBundle-Versionwas not incremented. This causesVersionBumpRequiredExceptionfor every PR CI run.This PR bumps the micro version for all affected bundles and features to resolve the baseline failures.