add ITs for policy entry references (eclipse-ditto/ditto#2423)#29
Open
thjaeckle wants to merge 3 commits intoeclipse-ditto:mainfrom
Open
add ITs for policy entry references (eclipse-ditto/ditto#2423)#29thjaeckle wants to merge 3 commits intoeclipse-ditto:mainfrom
thjaeckle wants to merge 3 commits intoeclipse-ditto:mainfrom
Conversation
Replace entriesAdditions and importsAliases integration tests with new policy entry references tests, covering import references (inheriting resources from imported entries), local references (inheriting subjects from local entries), combined references, and referential integrity validation (409 on delete conflicts, 400 on broken references). New test classes: - PolicyEntryReferencesIT: CRUD + referential integrity (18 tests) - PolicyEntryImportReferencesIT: import reference behavior (19 tests) - PolicyEntryLocalReferencesIT: local reference behavior (9 tests) - PolicyEntryCombinedReferencesIT: import + local combined (7 tests) Adapted existing tests: - PolicyImportTransitiveImportsIT: use import references in setup - PolicyEntryImportableSubResourcesIT: use import references in setup - SearchWithTransitiveImportsIT: use import references in setup Deleted 8 obsolete test files for entriesAdditions/importsAliases. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
…nvalid chaining test - PolicyEntryReferencesIT: expect CREATED (201) on first PUT of references instead of NO_CONTENT (204); keep 204 for subsequent replacement PUTs - PolicyEntryCombinedReferencesIT: remove localReferenceToEntryThatHas ImportReferenceChains — local references resolve one level only, they do not transitively inherit through other entries' import references Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
- PolicyEntryReferencesIT: add AllowedImportAddition.SUBJECTS to template DEFAULT entry so import references with own subjects are accepted (Ditto now validates allowedImportAdditions at write time) - PolicyEntryImportReferencesIT: importRefWithResourceAdditionsAllowed must not include own subjects when template only allows RESOURCES - PolicyEntryImportableSubResourcesIT: fix 201-vs-204 on first PUT references; remove own resource from user-access entry when testing subject-only additions Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
entriesAdditionsandimportsAliasesintegration tests with new policy entryreferencestests, aligning with eclipse-ditto/ditto#2424entriesAdditionsentriesAdditions/importsAliasesconceptsNew test classes
PolicyEntryReferencesIT/entries/{label}/references+ referential integrityPolicyEntryImportReferencesITPolicyEntryLocalReferencesITPolicyEntryCombinedReferencesIT