just passed props down and small formatting#279
Closed
Conversation
haschek
reviewed
Jun 4, 2025
| /** Optional height of the component */ | ||
| height?: number | string; | ||
| /** Set read-only mode. Default: false */ | ||
| readOnly?: boolean; |
Member
There was a problem hiding this comment.
readOnly can be set but then it is not used, is it?
| /** Optional height of the component */ | ||
| height?: number | string; | ||
| /** Set read-only mode. Default: false */ | ||
| readOnly?: boolean; |
| showScrollBar={showScrollBar} | ||
| multiline={multiline} | ||
| onMouseDown={handleInputMouseDown} | ||
| height={height} |
Member
There was a problem hiding this comment.
height is set via <CodeAutocompleteField /> in Silk?
Contributor
Author
There was a problem hiding this comment.
Yes, for one of the editors. also readOnly in certain cases. I noticed that <CodeAutoCompleteField /> didn't accept them when it could be configured via<CodeEditor />
Member
There was a problem hiding this comment.
But how readOnly forwarded if it is not used in the code (hight is used)), not directly, not via something like ...otherProps, have I overseen something?
Contributor
Author
There was a problem hiding this comment.
I have made the modifications, thanks a lot
arausly
deleted the
feature/supportProjectVariableAutocompletion-CMEM-5572
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.