Open
Conversation
🦋 Changeset detectedLatest commit: faeea27 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new evo-toast-dialog tag to evo-marko, aligning the toast dialog implementation with native <dialog> semantics (non-modal via .show()), and updates Skin toast-dialog styles to support <dialog> open/close animations.
Changes:
- Added native
<dialog>-based toast open/close keyframe animations and UA style resets in Skin. - Introduced the new
evo-toast-dialogMarko component with header/close/footer attr-tag API andopencontrol. - Added Storybook story plus SSR + browser tests for the new component.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/skin/src/sass/toast-dialog/toast-dialog.scss | Adds keyframe animations and <dialog>-specific resets while keeping legacy transition classes deprecated. |
| packages/skin/dist/toast-dialog/toast-dialog.css | Regenerated dist CSS reflecting new <dialog> animation/reset rules. |
| packages/evo-marko/src/tags/evo-toast-dialog/toast-dialog.stories.ts | Adds Storybook metadata/argTypes and default story wiring. |
| packages/evo-marko/src/tags/evo-toast-dialog/test/test.server.ts | Adds SSR snapshot coverage for default and open states. |
| packages/evo-marko/src/tags/evo-toast-dialog/test/test.browser.ts | Adds browser assertions for element/attrs/classes and basic structure. |
| packages/evo-marko/src/tags/evo-toast-dialog/style.ts | Wires Skin toast-dialog styles into the component. |
| packages/evo-marko/src/tags/evo-toast-dialog/index.marko | Implements the new <dialog>-based toast component and close behavior. |
| packages/evo-marko/src/tags/evo-toast-dialog/examples/default.marko | Provides an interactive open/close example used by Storybook. |
| packages/evo-marko/src/tags/evo-toast-dialog/README.md | Adds component README and documentation links. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<evo-toast-dialog>componentDifferences from
<ebay-toast-dialog><dialog>instead of<aside>@animationinstead oftransition<@close>attr tag instead ofa11yCloseTextopen(withopenChange)