Skip to content

chore(dashboard-api): use billing url#2402

Merged
jakubno merged 2 commits intomainfrom
chore/use-billing-url
Apr 15, 2026
Merged

chore(dashboard-api): use billing url#2402
jakubno merged 2 commits intomainfrom
chore/use-billing-url

Conversation

@jakubno
Copy link
Copy Markdown
Member

@jakubno jakubno commented Apr 15, 2026

remove the direct dependency on billing server

@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 15, 2026

PR Summary

Medium Risk
Changes Terraform to stop discovering the billing server URL from Cloud Run and instead read it from a Secret Manager secret, which could break deployments if the new secret is missing or misconfigured.

Overview
Updates the GCP Nomad Terraform so dashboard_api no longer depends on looking up the billing service in Cloud Run; it now sources the billing server URL from a Secret Manager secret (while keeping the API token secret-based), reducing direct coupling to the billing server deployment.

Reviewed by Cursor Bugbot for commit 4b6cd04. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a503bf4. Configure here.

Comment thread iac/provider-gcp/nomad/main.tf Outdated
Comment thread iac/provider-gcp/nomad/main.tf Outdated
@jakubno jakubno requested review from sitole and removed request for ValentaTomas and dobrac April 15, 2026 14:25
@jakubno jakubno merged commit 67e02fe into main Apr 15, 2026
45 checks passed
@jakubno jakubno deleted the chore/use-billing-url branch April 15, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants