fix(orchestrator): add HOST_BUSYBOX_DIR to local dev env#2399
Conversation
Commit bba0313 moved busybox from compile-time go:embed to runtime disk read via HOST_BUSYBOX_DIR, but didn't add the variable to .env.local. Without it, local-dev builds fail trying to read busybox from /fc-busybox (the production default). Point HOST_BUSYBOX_DIR at .busybox, the local fetch-busybox output directory. Fixes: bba0313 ("refactor(orchestrator): move busybox from compile-time embed to runtime disk read (#2326)")
PR SummaryLow Risk Overview Reviewed by Cursor Bugbot for commit 897880b. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
LGTM — simple one-line config fix restoring local-dev functionality.
Extended reasoning...
Overview
Single-line addition to packages/orchestrator/.env.local, pointing HOST_BUSYBOX_DIR at .busybox (the local fetch-busybox output directory). No production code is touched.
Security Risks
None. This is a local development env file, not a production secret or auth-sensitive config. The value is a relative path to a local directory.
Level of Scrutiny
Minimal scrutiny required. This is a trivial developer-experience fix: a missing env var that causes local builds to fail. The fix is exactly one line, obviously correct, and consistent with how other local paths are configured in the same file.
Other Factors
No bugs found by the bug hunting system. The description clearly explains the root cause (a prior commit forgot to add the variable). The path .busybox matches the documented local fetch-busybox output convention and aligns with the pattern of other relative paths in this file.
Commit bba0313 moved busybox from compile-time go:embed to runtime disk read via
HOST_BUSYBOX_DIR, but didn't add the variable to.env.local. Without it, local-dev builds fail trying to read busybox from/fc-busybox(the production default).Point
HOST_BUSYBOX_DIRat.busybox, the local fetch-busybox output directory.