Skip to content

fix(orchestrator): add HOST_BUSYBOX_DIR to local dev env#2399

Merged
arkamar merged 1 commit intomainfrom
fix/local-dev-busybox
Apr 15, 2026
Merged

fix(orchestrator): add HOST_BUSYBOX_DIR to local dev env#2399
arkamar merged 1 commit intomainfrom
fix/local-dev-busybox

Conversation

@arkamar
Copy link
Copy Markdown
Contributor

@arkamar arkamar commented Apr 15, 2026

Commit bba0313 moved busybox from compile-time go:embed to runtime disk read via HOST_BUSYBOX_DIR, but didn't add the variable to .env.local. Without it, local-dev builds fail trying to read busybox from /fc-busybox (the production default).

Point HOST_BUSYBOX_DIR at .busybox, the local fetch-busybox output directory.

Commit bba0313 moved busybox from compile-time go:embed to runtime
disk read via HOST_BUSYBOX_DIR, but didn't add the variable to
.env.local. Without it, local-dev builds fail trying to read
busybox from /fc-busybox (the production default).

Point HOST_BUSYBOX_DIR at .busybox, the local fetch-busybox output
directory.

Fixes: bba0313 ("refactor(orchestrator): move busybox from compile-time embed to runtime disk read (#2326)")
@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 15, 2026

PR Summary

Low Risk
Low risk: only changes local development configuration, with no runtime or security-sensitive logic modifications.

Overview
Updates the orchestrator’s local dev .env.local to include HOST_BUSYBOX_DIR=.busybox, aligning local builds with the runtime busybox lookup so developers don’t accidentally fall back to the production /fc-busybox path.

Reviewed by Cursor Bugbot for commit 897880b. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — simple one-line config fix restoring local-dev functionality.

Extended reasoning...

Overview

Single-line addition to packages/orchestrator/.env.local, pointing HOST_BUSYBOX_DIR at .busybox (the local fetch-busybox output directory). No production code is touched.

Security Risks

None. This is a local development env file, not a production secret or auth-sensitive config. The value is a relative path to a local directory.

Level of Scrutiny

Minimal scrutiny required. This is a trivial developer-experience fix: a missing env var that causes local builds to fail. The fix is exactly one line, obviously correct, and consistent with how other local paths are configured in the same file.

Other Factors

No bugs found by the bug hunting system. The description clearly explains the root cause (a prior commit forgot to add the variable). The path .busybox matches the documented local fetch-busybox output convention and aligns with the pattern of other relative paths in this file.

@arkamar arkamar enabled auto-merge (squash) April 15, 2026 08:33
@arkamar arkamar merged commit 3dfab64 into main Apr 15, 2026
47 checks passed
@arkamar arkamar deleted the fix/local-dev-busybox branch April 15, 2026 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants