Fix ArgumentException for regex shorthand classes in Apache mod_rewrite tokenizer#66354
Open
slymanmrcan wants to merge 2 commits intodotnet:mainfrom
Open
Fix ArgumentException for regex shorthand classes in Apache mod_rewrite tokenizer#66354slymanmrcan wants to merge 2 commits intodotnet:mainfrom
slymanmrcan wants to merge 2 commits intodotnet:mainfrom
Conversation
…te tokenizer Replace Regex.Unescape() with custom UnescapeApacheString() that only handles Apache-specific escape sequences (quotes, spaces, backslashes) while preserving regex patterns like \d, \w, \s intact. Fixes dotnet#18555
github-actions
Bot
added
the
area-middleware
dotnet-policy-service
Bot
added
the
community-contribution
Author
|
@dotnet-policy-service agree |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18555
Problem
RewriteOptions.AddApacheModRewrite()throwsArgumentExceptionwhenrewrite rules contain regex shorthands like
\d,\w,\s.RewriteRule ^/(\d) /?num=\1
// → System.ArgumentException: Unrecognized escape sequence \d
Cause
Tokenizer.RemoveQuotesAndEscapeCharacters()callsRegex.Unescape()which doesn't recognize regex shorthand classes.
Fix
Replaced
Regex.Unescape()with a custom method that only unescapesApache-specific sequences (spaces, quotes, backslashes) and leaves
regex patterns untouched.
Tests
\d,\w,\sno longer throw