Open
Conversation
filzrev
force-pushed
the
chore-cleanup-test-codes
branch
from
74f4c1c to
d607de6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed in this PR
1. Modify code to use ImplicitUsing
Remove following namespace's
usingand addImplicitUsingon project file instead.XunitXunit.AbstrattionsIt's needed to simplify code changes on xUnit v3/tUnit migrations (#3065)
2. Modify structure of files that are shared between projects
Move these files under
Shareddirectory.And modify
Compileitem include/links to use wildcard when possible.(e.g
<Compile Include="..\BenchmarkDotNet.IntegrationTests\Shared\**\*.cs" Link="Shared\%(RecursiveDir)%(Filename)%(Extension)" />)3. Remove UTF-8 BOM on modified files
Additionally UTF8 BOM is removed on modified files.
Note:
dotnet formatcommand will be applied on solution-level later. (Currently it's not executed to avoid code conflict with existing PRs)4. Modify xUnit assembly name for DataDiscoverer
It's required because
Benchmark.Testsassembly reference on IntegrationTests are replaced to source-based link.In any way, DataDiscoverer will be removed when migrated to xUnit.v3 because it's not supported on xUnitv3.