Skip to content

PHP8 Compatibility: Annotate return types for jsonSerialize() implementations #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dmf-janw wants to merge 1 commit into
base: master
Choose a base branch
from
Open

PHP8 Compatibility: Annotate return types for jsonSerialize() implementations #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Management/Model/DataSource.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public static function createFromArray(array $data)
/**
* @return array
*/
public function jsonSerialize()
public function jsonSerialize(): array
{
return [
'type' => $this->type,
Expand Down
2 changes: 1 addition & 1 deletion src/Management/Model/DataSourceOptionBigCommerce.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public static function createFromArray(array $data)
/**
* @return string[]
*/
public function jsonSerialize()
public function jsonSerialize(): array
{
return [
'url' => $this->url,
Expand Down
2 changes: 1 addition & 1 deletion src/Management/Model/DataSourceOptionEkm.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public static function createFromArray(array $data)
/**
* @return string[]
*/
public function jsonSerialize()
public function jsonSerialize(): array
{
return [
'url' => $this->url,
Expand Down
2 changes: 1 addition & 1 deletion src/Management/Model/DataSourceOptionFile.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public static function createFromArray(array $data)
/**
* @return string[]
*/
public function jsonSerialize()
public function jsonSerialize(): array
{
return [
'url' => $this->url,
Expand Down
2 changes: 1 addition & 1 deletion src/Management/Model/DataSourceOptionMagento.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public static function createFromArray(array $data)
/**
* @return string[]
*/
public function jsonSerialize()
public function jsonSerialize(): array
{
return [
'url' => $this->url
Expand Down
2 changes: 1 addition & 1 deletion src/Management/Model/DataSourceOptionShopify.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public static function createFromArray(array $data)
/**
* @return string[]
*/
public function jsonSerialize()
public function jsonSerialize(): array
{
return [
'url' => $this->url,
Expand Down
2 changes: 1 addition & 1 deletion src/Management/Model/Index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public static function createFromArray(array $data)
/**
* @return array
*/
public function jsonSerialize()
public function jsonSerialize(): array
{
return [
'name' => $this->name,
Expand Down
2 changes: 1 addition & 1 deletion src/Management/Model/Item.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ public static function createFromArray(array $data)
/**
* @return array
*/
public function jsonSerialize()
public function jsonSerialize(): array
{
return array_merge([
'id' => $this->id,
Expand Down
2 changes: 1 addition & 1 deletion src/Management/Model/SearchEngine.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ public function isHasGrouping()
/**
* @return array
*/
public function jsonSerialize()
public function jsonSerialize(): array
{
return [
'language' => $this->language,
Expand Down