Conversation
fliiiix
commented
Apr 2, 2026
fliiiix
commented
Apr 2, 2026
fliiiix
force-pushed
the
feature/web-cleanup
branch
from
b492c12 to
124c133
Compare
randombenj
approved these changes
Apr 7, 2026
Member
randombenj
left a comment
randombenj
left a comment
There was a problem hiding this comment.
Nice, yeah agreed that we should keep drpendencies as few as possible
fliiiix
force-pushed
the
feature/web-cleanup
branch
from
124c133 to
ba59990
Compare
fliiiix
force-pushed
the
feature/web-cleanup
branch
from
3e3b569 to
fe1679a
Compare
Member
Author
|
@ioasjfopas i picked now the solution from @tbuerli-komax and this seems to persist the i testest a few things and didn't notice any issues with the current version |
Contributor
|
From my point of view, this fixes the browser-back trough latest navigation. Other than that, I just saw that the following two files can be removed as the only reference to them gets removed in the last commit:
|
fliiiix
force-pushed
the
feature/web-cleanup
branch
from
fe1679a to
d47ffbc
Compare
Member
Author
|
good catch removed the unused files |
Back navigation trough pages showing the "lastest" version, when the version is for example called v1.0.1, by splitting version and displayVersion in the code
fliiiix
force-pushed
the
feature/web-cleanup
branch
from
d47ffbc to
0cb9c37
Compare
Member
Author
|
thanks @tbuerli-komax for the navigation fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
long term i think it would be better to not have any of this js crap 🙈