fix: restore the Snapshot::new internal API#2425
Draft
rtyler wants to merge 1 commit intodelta-io:mainfrom
Draft
fix: restore the Snapshot::new internal API#2425rtyler wants to merge 1 commit intodelta-io:mainfrom
rtyler wants to merge 1 commit intodelta-io:mainfrom
Conversation
This APi was removed in the upstream delta-io#2385 but this is a load-bearing API for delta-rs. The removal was not related to the change and seems like an erroneous removal that wasn't caught in review. Signed-off-by: R. Tyler Croy <rtyler@brokenco.de>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2425 +/- ##
==========================================
- Coverage 88.32% 88.31% -0.01%
==========================================
Files 171 171
Lines 56727 56733 +6
Branches 56727 56733 +6
==========================================
Hits 50103 50103
- Misses 4704 4710 +6
Partials 1920 1920 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This APi was removed in the upstream #2385 but this is a load-bearing API for delta-rs. The removal was not related to the change and seems like an erroneous removal that wasn't caught in review.