Adds custom deployment config support.#163
Open
rodrigosalvatoreradix wants to merge 1 commit intodavidgf:masterfrom
Open
Adds custom deployment config support.#163rodrigosalvatoreradix wants to merge 1 commit intodavidgf:masterfrom
rodrigosalvatoreradix wants to merge 1 commit intodavidgf:masterfrom
Conversation
- new customType property to indicate that should not use the prefix for default CodeDeploy config - adds unit test for the case where customType is true - adds test case where customType is true - adds readme descriptions of the new feature
f9ea6e0 to
41c29d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Currently the plugin does not support custom CodeDeploy deployment configuration.
This implementation creates a new customType property that when set to true, is does not adds de prefix CodeDeployDefault.Lambda prefix to the deployment configuration name.
This allow user to create their custom configurations in AWS CodeDeploy and reference them.
This implementation is fully retro-compatible since the property is not obligatory and not defining it default to the current behavior of adding the prefix.
This implementation addresses the issue #155
Types of changes
What types of changes does your code introduce to the plugin?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
This solution was chosen because its fully retro-compatible and amount to the least amount of change to the current code. Just a single optional property that gives a lot of freedom regarding choosing your CodeDeploy deployment config.