Conversation
|
|
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@swamimalode07 is attempting to deploy a commit to the Databuddy OSS Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile SummaryThis PR revamps the docs landing page with a new hero section (tabbed iframe demo), testimonials marquee, FAQ accordion, feature grid, trusted-by logo groups, an animated wordmark, a redesigned navbar, and a new footer with CTA banner and newsletter form.
Confidence Score: 4/5Safe to merge after fixing the duplicate trusted-by data and the flex-row/flex-col layout bug in the footer. One clear P1 (all three TrustedBy sections show identical companies, contradicting intent and the no-mock-data rule) and one layout P2 (flex-row always overridden by flex-col) need resolution. The rest of the changes are well-structured. apps/docs/components/landing/trusted-by.tsx (duplicate data arrays), apps/docs/components/footer.tsx (flex conflict on copyright row) Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
Page["Landing Page (page.tsx)"]
Navbar["Navbar"]
Hero["Hero\n(tabbed iframe demo)"]
BG["BackgroundFlow\n(SVG decoration)"]
Grid["GridCards\n(feature grid)"]
Trusted["TrustedBy\n(logo groups ⚠️ identical data)"]
Testimonials["Testimonials\n(dual marquee)"]
FAQ["FaqSection\n(accordion)"]
Footer["Footer\n(CTA + newsletter + links)"]
Wordmark["Wordmark\n(interactive SVG)"]
Page --> Navbar
Page --> Hero
Hero --> BG
Page --> Grid
Page --> Trusted
Page --> Testimonials
Page --> FAQ
Page --> Footer
Footer --> Wordmark
Reviews (2): Last reviewed commit: "fixed responsiveness" | Re-trigger Greptile |
| <Component | ||
| className={cn( | ||
| "flex items-center gap-2 px-4 py-4 font-medium text-muted-foreground text-sm hover:text-foreground", | ||
| "flex items-center gap-2 px-4 py-5 font-medium text-foreground/70 text-md hover:text-foreground", |
There was a problem hiding this comment.
text-md is not a valid Tailwind CSS utility
text-md does not exist in Tailwind CSS (v3 or v4) and is not defined as a custom utility anywhere in this project — there is no tailwind.config.* file and global.css has no text-md definition. Tailwind will silently ignore it, so no font-size will be applied to these elements. The standard equivalent for base/medium text is text-base (1rem).
This same invalid class appears in multiple places across the PR:
apps/docs/components/navbar-features-menu.tsx:92apps/docs/components/github-nav-mark.tsx:30apps/docs/components/navbar.tsx:59
| "flex items-center gap-2 px-4 py-5 font-medium text-foreground/70 text-md hover:text-foreground", | |
| "flex items-center gap-2 px-4 py-5 font-medium text-foreground/70 text-base hover:text-foreground", |
| <span | ||
| className="rounded-full border border-border/50 bg-muted/50 px-2.5 py-0.5 font-medium text-foreground/90 text-xs" | ||
| className="rounded-full px-1 py-0.5 pt-1 font-medium text-foreground text-md" | ||
| title="GitHub stars" |
There was a problem hiding this comment.
Redundant padding utilities on
GithubStarsBadge
py-0.5 sets both top and bottom padding to 0.125rem, but pt-1 then overrides the top to 0.25rem. While CSS cascade makes this work, it is confusing to read. Prefer explicit pb-0.5 pt-1 to make the intent clear:
| <span | |
| className="rounded-full border border-border/50 bg-muted/50 px-2.5 py-0.5 font-medium text-foreground/90 text-xs" | |
| className="rounded-full px-1 py-0.5 pt-1 font-medium text-foreground text-md" | |
| title="GitHub stars" | |
| <span | |
| className="rounded-full pb-0.5 pt-1 px-1 font-medium text-foreground text-base" | |
| title="GitHub stars" | |
| > |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
|
hola @izadoesdev , have a look at this PR |
| @@ -47,81 +44,158 @@ const industryLeaders = [ | |||
| }, | |||
| ]; | |||
|
|
|||
| // const engineerCompanies = [{ name: "Vercel" }, { name: "Mintlify" }]; | |||
| const analyticsMigrators = [ | |||
| { | |||
| name: "Open (YC W24)", | |||
| url: "https://open.cx", | |||
| logo: "/social/opencx-black.svg", | |||
| invert: true, | |||
| description: "AI-Powered customer support platform", | |||
| }, | |||
| { | |||
| name: "Autumn (S25)", | |||
| url: "https://useautumn.com", | |||
| logo: "/social/autumn.svg", | |||
| logoClass: "h-8 sm:h-10", | |||
| invert: false, | |||
| description: "Monetization infrastructure for developers", | |||
| }, | |||
| { | |||
| name: "Better Auth (YC X25)", | |||
| url: "https://www.better-auth.com", | |||
| logo: "/social/better-auth.svg", | |||
| invert: true, | |||
| description: "The #1 Authentication framework for TypeScript", | |||
| }, | |||
| { | |||
| name: "OpenCut", | |||
| url: "https://opencut.app", | |||
| logo: "/social/opencut.svg", | |||
| invert: true, | |||
| description: "Open source video editor", | |||
| }, | |||
| { | |||
| name: "Maza", | |||
| url: "https://maza.vc", | |||
| logo: "/social/maza.svg", | |||
| description: "Venture Capital Fund", | |||
| }, | |||
| { | |||
| name: "Figurable", | |||
| url: "https://figurable.ai", | |||
| logo: "/social/figurable.svg", | |||
| invert: true, | |||
| }, | |||
| ]; | |||
There was a problem hiding this comment.
Identical data in all three customer-segment arrays
juneCustomers, analyticsMigrators, and migratedOffOthers are defined with the exact same six companies. Every rendered LogoGroup block will show Open, Autumn, Better Auth, OpenCut, Maza, and Figurable — the page gives the impression these are three distinct audiences but they are not. The custom rule for this project also explicitly prohibits placeholder or duplicate mock data. The arrays need to be populated with their actual distinct company lists before this can ship.
Context Used: Basic guidelines for the project so vibe coders do... (source)
Description
Please include a summary of the change and which issue is fixed. Also include relevant motivation and context.
Checklist
Key Changes