Add return_on_result flag, to return immediately when a result is received#105
Open
noamraph wants to merge 5 commits intocs01:masterfrom
Open
Add return_on_result flag, to return immediately when a result is received#105noamraph wants to merge 5 commits intocs01:masterfrom
noamraph wants to merge 5 commits intocs01:masterfrom
Conversation
added 5 commits
December 26, 2023 09:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdSummary of changes
When I run a command and wait for the response, many times I don't want to wait for the entire timeout. So I added a flag return_on_result, which returns immediately when a response of type 'result' is received.
Notes:
IoManager.write()as well, together withtimeout_secandraise_error_on_timeoutwhich are also passed toget_gdb_response(). I added it afterraise_error_on_timeoutand beforeread_response, to keep it with the otherget_gdb_response()flags. However, this will break code that setsread_responseas a positional argument (meaning:iomanager.write('-cmd', timeout, raise_error_on_timeout, read_response). I leave it up to you to decide if you prefer better backwards compatibility or a more logical ordering of arguments.Test plan
I added an automated test which sets the
return_on_resultflag and makes sure it returns fast. You can see it fail by replacingTruewithFalseintest_gdbcontroller.py: