fix: Vite 8 (Rolldown) compatibility for content scripts#1149
Open
sheldhur wants to merge 1 commit intocrxjs:mainfrom
Open
fix: Vite 8 (Rolldown) compatibility for content scripts#1149sheldhur wants to merge 1 commit intocrxjs:mainfrom
sheldhur wants to merge 1 commit intocrxjs:mainfrom
Conversation
Made-with: Cursor
|
Contributor
Author
|
@Toumash can you look at this? I can update the failed tests if you're ready to merge it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes for Vite 8 (Rolldown) compatibility when building Chrome extensions with content scripts:
Duplicate refIds:
this.emitFile({ type: "chunk", name: basename(file) })returns the samerefIdfor different files with the same basename (e.g.seller/content.tsx,cmp/content.tsx,marketplace/content.tsx). Only the first script gets itsfileNameresolved; the rest fail withContent script fileName is undefined.Wrong MAIN world loader path: The loader uses
./${fileName.split("/").at(-1)}which loses the subdirectory, producing a broken path.