Skip to content

Combo Drag For Grids.#6714

Draft
seanparsons wants to merge 5 commits intomasterfrom
feature/show-resize-handles
Draft

Combo Drag For Grids.#6714
seanparsons wants to merge 5 commits intomasterfrom
feature/show-resize-handles

Conversation

@seanparsons
Copy link
Copy Markdown
Contributor

Problem:

  • Show corner resize handles for grid items, even when they are stretch x stretch.
  • When resizing by it’s corner handles:
    • on an element that is stretch x stretch - both the spanning values get updated
    • on an element that is fixed x fixed - both the fixed values get updated in those units
    • on an element that is stretch x fixed or fixed x stretch - both the fixed value and the spanning value get updated accordingly.

Fix:

Commit Details:

Manual Tests:
I hereby swear that:

  • I opened a hydrogen project and it loaded
  • I could navigate to various routes in Play mode

- Removed `canResize` and the filtering of control parts based on it
  in `AbsoluteResizeControl`.
- Removed check from `basicResizeStrategy` which disallowed resizing
  for grid cells that are set to stretch.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 9, 2024

Try me

@relativeci
Copy link
Copy Markdown

relativeci bot commented Dec 9, 2024

#15390 Bundle Size — 58.21MiB (+0.01%).

678531d(current) vs d1d46c1 master#15388(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics  Change 3 changes Regression 1 regression
                 Current
#15390
     Baseline
#15388
Regression  Initial JS 41.18MiB(+0.02%) 41.18MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 18.24% 0%
No change  Chunks 20 20
No change  Assets 22 22
Change  Modules 4191(+0.05%) 4189
No change  Duplicate Modules 213 213
No change  Duplicate Code 27.24% 27.24%
No change  Packages 477 477
No change  Duplicate Packages 70 70
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#15390
     Baseline
#15388
Regression  JS 58.2MiB (+0.01%) 58.2MiB
Improvement  HTML 9.4KiB (-0.21%) 9.42KiB

Bundle analysis reportBranch feature/show-resize-handlesProject dashboard


Generated by RelativeCIDocumentationReport issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant