Open
Conversation
…ut it doesn't matter.
…to move-to-alexs-aws
dhimmel
approved these changes
Feb 12, 2018
Member
Author
|
BTW, this PR no longer changes the AZ because SES is not supported in us-east-2. |
|
LGTM - how is our Route53 being managed? |
Member
Author
|
Route53 is primarily managed through terraform, however the zone itself is not. I'm not sure why now... I had thought terraform didn't offer a way to create a zone, only reference it via a |
New collaborators: 0A053C53 Rich Jones <miserlou+alexs@gmail.com>
…ause it is a service linked role which makes it not scary that it has a *.
…e ECS with a passion.
…with health checks for ECS instances, and database access.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does a few things:
I tested that the syntax is parsable by terraform and that the resources I have IAM permissions to create are creatable, however I cannot create IAM roles so there are 13 resources which I cannot test the creation of.