fix: read host config skill paths in skill discovery#3473
Open
EnochLi15 wants to merge 2 commits intocode-yeongyu:devfrom
Open
fix: read host config skill paths in skill discovery#3473EnochLi15 wants to merge 2 commits intocode-yeongyu:devfrom
EnochLi15 wants to merge 2 commits intocode-yeongyu:devfrom
Conversation
Contributor
|
All contributors have signed the CLA. Thank you! ✅ |
There was a problem hiding this comment.
1 issue found across 12 files
Confidence score: 4/5
- Potential user-facing misbehavior: in
src/shared/host-skill-config.ts, blank/whitespace-only host skill paths or URLs can yield an empty string source and trigger unintended skill discovery. - Overall risk is limited to a specific edge case in source filtering, so this looks safe to merge with a small follow-up fix.
- Pay close attention to
src/shared/host-skill-config.ts- ensure blank/whitespace-only paths are filtered before building sources.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/shared/host-skill-config.ts">
<violation number="1" location="src/shared/host-skill-config.ts:10">
P2: Filter out blank/whitespace-only host skill paths and URLs before building `sources`; otherwise an empty string source is treated as `configDir` and triggers unintended skill discovery.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config.skills.pathsandconfig.skills.urlsinto omo skill sourcesskill()discoveryTesting
bun test src/tools/skill/zauc-mocks-skill-tools/tools.test.tsbun test src/plugin-handlers/command-config-handler.test.tsbun test src/plugin-handlers/agent-config-handler-agents-skills.test.tsbun run typecheckSummary by cubic
Include host-defined skill sources from config.skills.paths and config.skills.urls in skill discovery across tools, commands, and agents. Skips blank entries and prevents missing skills when configured only at the host level.
config.skills.paths/urlstoSkillsConfigand merge into discovery without duplicates. Ignore blank paths/URLs.hostSkillConfigStoreduring config handling and expose it to tools.Written for commit 160f79a. Summary will update on new commits.