Skip to content

fix: read host config skill paths in skill discovery#3473

Open
EnochLi15 wants to merge 2 commits intocode-yeongyu:devfrom
EnochLi15:fix/read-host-config-skills
Open

fix: read host config skill paths in skill discovery#3473
EnochLi15 wants to merge 2 commits intocode-yeongyu:devfrom
EnochLi15:fix/read-host-config-skills

Conversation

@EnochLi15
Copy link
Copy Markdown

@EnochLi15 EnochLi15 commented Apr 16, 2026

Summary

  • adapt host config.skills.paths and config.skills.urls into omo skill sources
  • cache the adapted host skill config during the config hook and merge it into skill() discovery
  • include the same host-config-backed skills in command injection and builtin agent awareness

Testing

  • bun test src/tools/skill/zauc-mocks-skill-tools/tools.test.ts
  • bun test src/plugin-handlers/command-config-handler.test.ts
  • bun test src/plugin-handlers/agent-config-handler-agents-skills.test.ts
  • bun run typecheck

Summary by cubic

Include host-defined skill sources from config.skills.paths and config.skills.urls in skill discovery across tools, commands, and agents. Skips blank entries and prevents missing skills when configured only at the host level.

  • Bug Fixes
    • Adapt host config.skills.paths/urls to SkillsConfig and merge into discovery without duplicates. Ignore blank paths/URLs.
    • Cache adapted config via hostSkillConfigStore during config handling and expose it to tools.
    • Include host-config-backed skills in command injection and builtin agent creation.

Written for commit 160f79a. Summary will update on new commits.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 16, 2026

All contributors have signed the CLA. Thank you! ✅
Posted by the CLA Assistant Lite bot.

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 12 files

Confidence score: 4/5

  • Potential user-facing misbehavior: in src/shared/host-skill-config.ts, blank/whitespace-only host skill paths or URLs can yield an empty string source and trigger unintended skill discovery.
  • Overall risk is limited to a specific edge case in source filtering, so this looks safe to merge with a small follow-up fix.
  • Pay close attention to src/shared/host-skill-config.ts - ensure blank/whitespace-only paths are filtered before building sources.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/shared/host-skill-config.ts">

<violation number="1" location="src/shared/host-skill-config.ts:10">
P2: Filter out blank/whitespace-only host skill paths and URLs before building `sources`; otherwise an empty string source is treated as `configDir` and triggers unintended skill discovery.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment thread src/shared/host-skill-config.ts Outdated
@EnochLi15
Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Apr 16, 2026
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 2 files (changes from recent commits).

Auto-approved: Additive changes for host skill discovery with comprehensive tests and safe handling of empty/missing configurations. Merging logic prevents duplicates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant