fix(session-recovery): add thinking_block_modified error detection and recovery#3470
Open
omer-koren wants to merge 1 commit intocode-yeongyu:devfrom
Open
fix(session-recovery): add thinking_block_modified error detection and recovery#3470omer-koren wants to merge 1 commit intocode-yeongyu:devfrom
omer-koren wants to merge 1 commit intocode-yeongyu:devfrom
Conversation
…ed' errors Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Contributor
|
All contributors have signed the CLA. Thank you! ✅ |
There was a problem hiding this comment.
No issues found across 3 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Safely adds detection and recovery for Bedrock thinking block errors by reusing existing logic; includes regression tests and is isolated from other error handling paths.
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
thinking/redacted_thinkingsignature errors after compaction corrupts the latest assistant thinking block signatures.experimental.auto_resume: truewere left without an automatic recovery path when the provider rejected the modified thinking blocks.Solution
thinking_block_modifiedrecovery error type and detect the Bedrockthinking blocks cannot be modifiedfailure patternrecoverThinkingDisabledViolationto strip corrupted thinking blocks, then auto-resume the session when enabledTesting
bun run typecheckbun test src/hooks/session-recovery/bun run buildSummary by cubic
Detects and recovers from Bedrock “thinking block modified” errors caused by compaction, restoring auto-resume when enabled and preventing stuck sessions.
thinking_block_modifiedrecovery type; detects Bedrock “thinking … cannot be modified” errors (full and simple variants).Written for commit b6ad494. Summary will update on new commits.