Implement read and commit functionality in PartialTrieDb#2205
Draft
goodlyrottenapple wants to merge 1 commit intosam/partial_trie_dbfrom
Draft
Implement read and commit functionality in PartialTrieDb#2205goodlyrottenapple wants to merge 1 commit intosam/partial_trie_dbfrom
goodlyrottenapple wants to merge 1 commit intosam/partial_trie_dbfrom
Conversation
goodlyrottenapple
force-pushed
the
sam/partial_trie_db_2
branch
from
adffa85 to
794ce12
Compare
| // read_account / read_storage on the PartialTrieDb and compared. | ||
| // | ||
| // Returns true if verification passes. | ||
| bool verify_witness( |
Contributor
Author
There was a problem hiding this comment.
This code is only for debugging and shouldn't be called in CI, but might nonetheless be useful to keep behind a flag for diagnosing witness mismatches.
| /// Like read_account, but returns std::nullopt (outer) when the lookup | ||
| /// hits an unresolved HashStub. | ||
| std::optional<std::optional<Account>> | ||
| read_account_maybe(Address const &addr); |
Contributor
Author
There was a problem hiding this comment.
This method, together with read_storage_maybe, are only needed for debug and should not be called in zkvm execution. They are used in verify_witness. If we decide to drop that method, we should remove these too.
goodlyrottenapple
force-pushed
the
sam/partial_trie_db_2
branch
from
794ce12 to
7d8bc84
Compare
goodlyrottenapple
force-pushed
the
sam/partial_trie_db
branch
3 times, most recently
from
f8dc4ee to
27e8e93
Compare
goodlyrottenapple
force-pushed
the
sam/partial_trie_db_2
branch
from
7d8bc84 to
7d647d9
Compare
goodlyrottenapple
force-pushed
the
sam/partial_trie_db
branch
from
27e8e93 to
607691e
Compare
goodlyrottenapple
force-pushed
the
sam/partial_trie_db_2
branch
from
7d647d9 to
64774ea
Compare
goodlyrottenapple
force-pushed
the
sam/partial_trie_db
branch
2 times, most recently
from
0c17d70 to
f49ba87
Compare
goodlyrottenapple
force-pushed
the
sam/partial_trie_db_2
branch
from
64774ea to
d8c18aa
Compare
goodlyrottenapple
force-pushed
the
sam/partial_trie_db
branch
from
f49ba87 to
44862d8
Compare
goodlyrottenapple
force-pushed
the
sam/partial_trie_db_2
branch
from
d8c18aa to
45ca9c3
Compare
goodlyrottenapple
force-pushed
the
sam/partial_trie_db
branch
from
44862d8 to
90b42cc
Compare
goodlyrottenapple
force-pushed
the
sam/partial_trie_db_2
branch
from
45ca9c3 to
126f468
Compare
Baltoli
force-pushed
the
sam/partial_trie_db
branch
from
90b42cc to
ff24ec2
Compare
goodlyrottenapple
force-pushed
the
sam/partial_trie_db
branch
2 times, most recently
from
f4a3813 to
d1e6f74
Compare
Baltoli
force-pushed
the
sam/partial_trie_db
branch
from
d1e6f74 to
0690f9f
Compare
goodlyrottenapple
force-pushed
the
sam/partial_trie_db
branch
2 times, most recently
from
40c9f98 to
6d36b9a
Compare
Co-Authored-By: Claude Sonnet 4.7 <noreply@anthropic.com>
goodlyrottenapple
force-pushed
the
sam/partial_trie_db_2
branch
from
126f468 to
c187927
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.