Fix and improve slow-list compaction pacing#2177
Draft
Chen-Yifan wants to merge 3 commits intomainfrom
Draft
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates MPT on-disk compaction pacing logic (especially for the slow list) by persisting per-compaction metrics and using them to compute the next compaction stride, with associated logging adjustments.
Changes:
- Rename/expand disk-growth snapshotting into
update_compaction_state()and add slow-list GC efficiency tracking. - Rework
advance_compact_offsets()to gate fast compaction by chunk thresholds and to scale slow compaction by prior GC efficiency. - Restructure compaction stats logging output for fast/slow lists.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
category/mpt/update_aux.cpp |
Implements new compaction pacing logic (fast/slow) and updates stats logging. |
category/mpt/trie.hpp |
Renames the helper API and adds state needed for slow-list GC efficiency tracking. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Chen-Yifan
force-pushed
the
vicky/compact-slow-list
branch
from
cc85dfb to
26ba7ac
Compare
from fast-list so each list's stats are printed independently
…paction upsert Move gc_efficiency computation into update_compaction_state() (renamed from update_disk_growth_data) so it is captured right after the compaction upsert, before stats are cleared.
…mpact_offsets(), and scale slow-list compaction by gc_efficiency relative to disk growth Replace the fixed cap (min of growth+1 and gc_efficiency) with a formula that scales growth by gc_efficiency / breakeven. Above the breakeven (4), compaction outruns growth to reduce backlog; below it, compaction backs off when recirculation is heavy.
Chen-Yifan
force-pushed
the
vicky/compact-slow-list
branch
from
26ba7ac to
74189bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.