Skip to content

fix(apiserver): register OpenAPI v2 spec for aggregation #1803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
praveenrewar merged 2 commits into from
Apr 6, 2026
+15 −3
Merged

fix(apiserver): register OpenAPI v2 spec for aggregation #1803

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ab5eb3
fix(apiserver): register OpenAPI v2 spec for aggregation
himsngh Mar 26, 2026
15ece02
fix(apiserver): initialize OpenAPI specs before applyTo and enforce v…
himsngh Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions pkg/apiserver/apiserver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,14 +231,26 @@ func newServerConfig(aggClient aggregatorclient.Interface, opts NewAPIServerOpts
}

serverConfig := genericapiserver.NewRecommendedConfig(Codecs)
if err := recommendedOptions.ApplyTo(serverConfig); err != nil {
return nil, err
}

serverConfig.OpenAPIV3Config = genericapiserver.DefaultOpenAPIV3Config(
openapi.GetOpenAPIDefinitions,
genericopenapi.NewDefinitionNamer(Scheme))
serverConfig.OpenAPIV3Config.Info.Title = "Kapp-controller"
serverConfig.OpenAPIV3Config.Info.Version = "v1alpha1"

// Register OpenAPI v2 configuration to satisfy the Kubernetes Aggregation Controller.
// In K8s 1.30+, the aggregator syncs both v2 and v3 specs; providing v2 prevents
// "resource not found" errors in the kube-apiserver logs (Fixes #1703).
serverConfig.OpenAPIConfig = genericapiserver.DefaultOpenAPIConfig(
openapi.GetOpenAPIDefinitions,
genericopenapi.NewDefinitionNamer(Scheme))
Comment thread
himsngh marked this conversation as resolved.
serverConfig.OpenAPIConfig.Info.Title = "Kapp-controller"
serverConfig.OpenAPIConfig.Info.Version = "v1alpha1"

if err := recommendedOptions.ApplyTo(serverConfig); err != nil {
return nil, err
}

return serverConfig, nil
}

Expand Down
Loading