Avoid blocking queued syncs on stale save errors#38
Open
mmtftr wants to merge 1 commit intocaenrigen:mainfrom
Open
Avoid blocking queued syncs on stale save errors#38mmtftr wants to merge 1 commit intocaenrigen:mainfrom
mmtftr wants to merge 1 commit intocaenrigen:mainfrom
Conversation
Owner
|
Thanks for debugging it and the suggested fix I will have to look at this into more detail when I find a bit of time, it touches on functions that are used for a few different purposes beside the sync |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
When a sync triggered by
onDidSaveTextDocumentfailed, the extension awaitedvscode.window.showErrorMessage(...). That kept the task promise unresolved and prevented the next queuedsync for the same file from starting.
Rapid consecutive saves also produced error output for obsolete sync attempts, even when a newer save had
already superseded the failing task.
Fix
runJupytextVerification
(node 24.11.1)
npm run compilenpm run lint