service: Add RuntimeDirectory and LogsDirectory to unit

[jbergstroem]

Caddy supports listening on a unix socket. To make it easier for users to manage said socket (including permissions), let systemd handle the creation of it.

[francislavoie]

So if I understand correctly, this will create /run/caddy dir owned by the caddy user?

https://www.freedesktop.org/software/systemd/man/latest/systemd.exec.html#RuntimeDirectory=

I'm realizing there's also LogsDirectory, we should probably use that instead of this stuff:

dist/scripts/postinstall.sh

Line 24 in 49a805b

mkdir -p /var/log/caddy

[jbergstroem]

So if I understand correctly, this will create /run/caddy dir owned by the caddy user?

freedesktop.org/software/systemd/man/latest/systemd.exec.html#RuntimeDirectory=

Yes.

I'm realizing there's also LogsDirectory, we should probably use that instead of this stuff:

dist/scripts/postinstall.sh

Line 24 in 49a805b

mkdir -p /var/log/caddy

Let me have a look (test) and iterate.

[jbergstroem]

Added the line locally and removed the log directory followed by a restart. The log directory was correctly created with 0755 permissions/caddy:caddy as owner. If we want other permissions, I can change that too.

[francislavoie]

Thanks, LGTM!

I want to wait for @carlwgeorge's review though, he may have opinions on this.

[jbergstroem]

Ran into this issue again the other day! Any more input, review wise?

[carlwgeorge]

I wasn't aware that the deb package was creating a log directory. The rpm doesn't do that. Either way, the default configuration writes process logs to stderr, and doesn't write requests logs at all. It also doesn't listen on a unix socket. I don't think we should be pro-actively creating directories that aren't used by default. I think these directives make more sense as local unit file overrides.

[francislavoie]

We create the directory so that it's there if users want to use it for access logs. I think it's a common enough need that it's harmless to do so just to save users a step which may be surprising/confusing to require otherwise.

WDYT about the RuntimeDirectory @carlwgeorge? Same idea here, it's just a nice-to-have I think which would save a manual step for most users.

[carlwgeorge]

It's not surprising or confusing for users who change root to ensure the directory they point it to exists. Why would it be surprising or confusing for users to ensure (or have systemd ensure) the directory for their custom logging or unix socket exists? Sure the directive is harmless, but I'm just not convinced it's necessary in the default unit file for everyone. That combined with the simplicity of unit file overrides for adding local directives makes me lean towards no on this.