Skip to content

fix: respect connectTimeoutMs when waiting for first top-level page #2010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
octo-patch wants to merge 1 commit into from
+8 −1
Closed

fix: respect connectTimeoutMs when waiting for first top-level page #2010

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/core/lib/v3/understudy/context.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,14 @@ export class V3Context {
opts?.localBrowserLaunchOptions ?? null,
);
await ctx.bootstrap();
await ctx.ensureFirstTopLevelPage(getFirstTopLevelPageTimeoutMs());
// Allow connectTimeoutMs to also govern how long we wait for the first
// top-level page to appear. On slow machines the browser may need more
// time after the CDP socket is open before the initial page registers.
const firstPageTimeoutMs = Math.max(
opts?.localBrowserLaunchOptions?.connectTimeoutMs ?? 0,
getFirstTopLevelPageTimeoutMs(),
);
await ctx.ensureFirstTopLevelPage(firstPageTimeoutMs);
return ctx;
};

Expand Down
Loading