fix[closes #4482]: [Bug]: KDE/Wayland Desktop Entry creation failed#4485
Open
g33z wants to merge 3 commits intobottlesdevs:mainfrom
Open
fix[closes #4482]: [Bug]: KDE/Wayland Desktop Entry creation failed#4485g33z wants to merge 3 commits intobottlesdevs:mainfrom
g33z wants to merge 3 commits intobottlesdevs:mainfrom
Conversation
Contributor
Author
|
Only to connect the two, I am mentioning #4012 here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Observation
xdg-desktop-portal-kdehas a buggy Dynamic Launcher portal implementation. 👯The QML dialog (
DynamicLauncherDialog.qml) is missing required properties (launcherIcon,launcherName), causing the portal to reject requests before the confirmation dialog even displays.The code
When the portal fails, there is the fallback creating .desktop files manually.
However that fallback only catches errors from
dynamic_launcher_install(), not fromdynamic_launcher_prepare_install_finish()where KDE's rejection actually occurs.I caught the error within libportal and added a general fallback functionality adding the .desktop files to
~/.local/share/applicationsfor menu entries as well as~/Desktopfor actual desktop shortcuts.I did add the necessary permissions in the development build json.
Hope that is how that was intended... 😅
Fixes #4482
Type of change
How Has This Been Tested?
I created multiple entries and observed the logs inside the terminal.
Provide instructions so we can reproduce.