Skip to content

[PM-33518] feat: Add isInAppUpgradeAvailableFlow to PremiumStateManager#6795

Draft
SaintPatrck wants to merge 1 commit intopremium-upgrade/PM-33517-settings-premium_bakfrom
premium-upgrade/PM-33518-upgrade-available-flow
Draft

[PM-33518] feat: Add isInAppUpgradeAvailableFlow to PremiumStateManager#6795
SaintPatrck wants to merge 1 commit intopremium-upgrade/PM-33517-settings-premium_bakfrom
premium-upgrade/PM-33518-upgrade-available-flow

Conversation

@SaintPatrck
Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-33518

📔 Objective

Add a consolidated isInAppUpgradeAvailableFlow to PremiumStateManager that combines isInAppBillingSupportedFlow and the MobilePremiumUpgrade feature flag into a single observable signal.

Stacked on PM-33517 PR (settings/premium management)

Changes

  • Add isInAppUpgradeAvailableFlow: StateFlow<Boolean> to PremiumStateManager interface
  • Implement in PremiumStateManagerImpl by combining billing support and feature flag flows
  • Add unit tests for the new flow covering all flag/billing combinations

@SaintPatrck SaintPatrck added the ai-review-vnext Request a Claude code review using the vNext workflow label Apr 14, 2026
@github-actions github-actions bot added app:password-manager Bitwarden Password Manager app context t:feature Change Type - Feature Development labels Apr 14, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 14, 2026

Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR adds a new isInAppUpgradeAvailableFlow property to PremiumStateManager that combines isInAppBillingSupportedFlow and the MobilePremiumUpgrade feature flag into a single observable signal. The implementation follows the established combine + stateIn pattern already used by isPremiumUpgradeBannerEligibleFlow in the same class. Unit tests cover all four boolean combinations of the two input flows.

No findings.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 14, 2026

Logo
Checkmarx One – Scan Summary & Details21361e27-c2ca-4440-9395-a91030bd55e8

Great job! No new security vulnerabilities introduced in this pull request

Combine isInAppBillingSupportedFlow and MobilePremiumUpgrade feature
flag into a single StateFlow for determining whether to route premium
upgrade CTAs to the in-app PlanScreen or the web vault URL.
@SaintPatrck SaintPatrck force-pushed the premium-upgrade/PM-33517-settings-premium_bak branch from eda128d to 581f032 Compare April 14, 2026 03:30
@SaintPatrck SaintPatrck force-pushed the premium-upgrade/PM-33518-upgrade-available-flow branch from 5d1322c to 65f09c8 Compare April 14, 2026 03:30
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.72%. Comparing base (581f032) to head (65f09c8).

Additional details and impacted files
@@                                Coverage Diff                                @@
##           premium-upgrade/PM-33517-settings-premium_bak    #6795      +/-   ##
=================================================================================
+ Coverage                                          85.66%   85.72%   +0.06%     
=================================================================================
  Files                                                831      828       -3     
  Lines                                              59011    58979      -32     
  Branches                                            8633     8634       +1     
=================================================================================
+ Hits                                               50553    50562       +9     
+ Misses                                              5468     5427      -41     
  Partials                                            2990     2990              
Flag Coverage Δ
app-data 17.40% <100.00%> (+0.01%) ⬆️
app-ui-auth-tools 20.25% <0.00%> (-0.01%) ⬇️
app-ui-platform 15.75% <0.00%> (-0.01%) ⬇️
app-ui-vault 25.83% <0.00%> (-0.01%) ⬇️
authenticator 6.53% <0.00%> (+0.02%) ⬆️
lib-core-network-bridge 4.26% <0.00%> (-0.01%) ⬇️
lib-data-ui 1.02% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-vnext Request a Claude code review using the vNext workflow app:password-manager Bitwarden Password Manager app context t:feature Change Type - Feature Development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant