AddressTest: use FieldSource and record for reading key/addr parameters#336
Open
msgilligan wants to merge 1 commit intomasterfrom
Open
AddressTest: use FieldSource and record for reading key/addr parameters#336msgilligan wants to merge 1 commit intomasterfrom
msgilligan wants to merge 1 commit intomasterfrom
Conversation
msgilligan
force-pushed
the
msgilligan/AddressTest-use-fieldsource-and-records
branch
from
9345770 to
c114dcb
Compare
msgilligan
changed the title
msgilligan
force-pushed
the
msgilligan/AddressTest-use-fieldsource-and-records
branch
from
c114dcb to
1ab0b0d
Compare
Member
|
Approved 3360ce9. |
msgilligan
force-pushed
the
msgilligan/AddressTest-use-fieldsource-and-records
branch
from
1ab0b0d to
d7da6b0
Compare
msgilligan
force-pushed
the
msgilligan/AddressTest-use-fieldsource-and-records
branch
from
d7da6b0 to
3007fdb
Compare
Member
Author
Cherry-picked and rebased. |
Member
Author
|
@schildbach I updated the PR description as it was trying to explain that this PR applies changes to a test/functionality that itself is incomplete, not that the PR is incomplete. The update makes things more clear. |
liamgilligan
approved these changes
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About
AddressTest: This is a WIP test in a WIP module that aims to implement Taproot functionality with secp-jdk and bitcoinj.The commit updated to
FieldSourcewas cherry-picked/merged and the remaining commit uses arecordinstead of the JupiterArgumentsclass.